fix: do not compare references to pointers to compare pointers #3236
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carllerche @hawkw Hi there, any chance to get a review? |
samueltardieu
force-pushed
the
push-yvyxvmkmrvtw
branch
from
252a380 to
db0bae3
Compare
|
Rebased |
jplatte
approved these changes
May 30, 2025
`self` and `other` are references, and the `ptr::eq()` call intends to determine if they designate the same object. Putting them behind another level of reference will always return `false`, as those short-lived references will be compared instead.
jplatte
force-pushed
the
push-yvyxvmkmrvtw
branch
from
db0bae3 to
bcabba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfandotherare references, and theptr::eq()call intends to determine if they designate the same object. Putting them behind another level of reference will always returnfalse, as those short-lived references will be compared instead.Solution
Remove the extra references.
As this is only an optimization which was missed, it is not possible to design a test which failed before this PR and succeeds after.