Run doc tests with miri in ci #7060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm… what's going on in |
Darksonn
reviewed
Jan 1, 2025
| @@ -399,6 +399,7 @@ jobs: | |||
| - name: miri | |||
| run: | | |||
| cargo miri nextest run --features full --lib --tests --no-fail-fast | |||
| cargo miri test --doc --all-features --no-fail-fast | |||
There was a problem hiding this comment.
The miri job is starting to take a rather long time. Could you add a new job for this, instead of adding additional work to the existing job? This will allow for parallelism.
RalfJung
reviewed
Jan 2, 2025
| @@ -1535,6 +1553,7 @@ impl UnixDatagram { | |||
| /// | |||
| /// # Examples | |||
| /// ``` | |||
| /// # if cfg!(miri) { return } // No `socketpair` in miri. | |||
There was a problem hiding this comment.
Hm, but we do have socketpair in Miri?
There was a problem hiding this comment.
Oops should be only the SOCK_DGRAM flag
fixed in #7063
RalfJung
reviewed
Jan 2, 2025
| @@ -421,6 +421,7 @@ impl Runtime { | |||
| /// # Examples | |||
| /// | |||
| /// ``` | |||
| /// # if cfg!(miri) { return } // Miri reports error when main thread terminated without waiting all remaining threads. | |||
There was a problem hiding this comment.
Specifically we report a leak; this can be ignored -- but maybe you want to detect memory leaks in the other tests.
There was a problem hiding this comment.
We definitely want the leak detection for lots of other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ran doc test with miri in CI. Since doc test couldn't be run through
cargo miri nextest run, it needs to be run separately usingcargo miri test. There are 844 successful tests and 72 ignored tests in total.Happy new year! 🎉
Tracked under #6812