fixed descriptor support #222
Conversation
A step in getting to the support of requests that have fixed descriptors created so that requests can then be written to make use of fixed descriptors.
|
Awesome! This is another feature I am looking for 😄. This also has interesting implications on the Send semantics of File which should probably be discussed. With normal fds, it is possible to make the File type Send. With fixed fds, I don't believe that the File type can be Send. Would it make sense to make two different File types (e.g. File and FixedFile), one of which uses normal Fds and is Send and one which uses Fixed Fds and is !Send? |
|
I'm not inclined to want two forms of File, FileFd and FileFixed, unless we find more reasons for letting the compiler differentiate one from the other. Maybe a different method set? Maybe a different lifetime or close semantics? |
|
Will have to resolve conflicts tomorrow. |
|
Converted to draft while it relies on my branch for the io-uring dependency. edit: the io-uring repo has the support for opcode::Close with a Fixed(fd) parameter. Now waiting for a new release to be issued but there's still at least one multi opcode being worked that is probably almost ready so we're holding off. |
|
Replaced by another PR, #256, which has the same code. The diffs against the mainline should be easier to follow. |
Support uring fixed descriptors, often also called direct descriptors by the io_uring man pages.