chore: support insert true DTCG shadow, prep TODOs for next major#373
Open
jorenbroekema wants to merge 1 commit intotokens-studio:mainfrom
Open
chore: support insert true DTCG shadow, prep TODOs for next major#373jorenbroekema wants to merge 1 commit intotokens-studio:mainfrom
jorenbroekema wants to merge 1 commit intotokens-studio:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prepares sd-transforms for some updates in Style Dictionary, while keeping backwards compatibility with v5.0.0.
Also added TODOs to clarify what changes to make for when sd-transforms does a breaking change to be on latest SD v5.x.x or even v6.
For now, we don't need a changeset/release for sd-transforms since I'm not removing the backwards compatibility we have in Style Dictionary until the next major release, see: https://github.com/style-dictionary/style-dictionary/pull/1643/changes#diff-a910c29ae52c0bba61129dd0dc3a9a3fee3293e35c3ecb177ec257e65119832cR1704 for more information about that.
The main goal is just to do the grunt of the work beforehand so it's easy to migrate this later :)