fix: pass usesDtcg flag to convertTokenData util (#361)#364
Merged
jorenbroekema merged 3 commits intotokens-studio:mainfrom Jun 26, 2025
Merged
fix: pass usesDtcg flag to convertTokenData util (#361)#364jorenbroekema merged 3 commits intotokens-studio:mainfrom
jorenbroekema merged 3 commits intotokens-studio:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 00084da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jorenbroekema
approved these changes
Jun 26, 2025
Contributor
|
Thanks for the fix :)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #361 by passing
usesDtcgflag toconvertTokenData.The unit test for
add font style > handles invalid fontweight structures e.g. mixing token group / token, also handles DTCG formatis failing.The test is expected to trigger an error, but it is not occurring due to the changes I made.
However, I am unsure of the exact meaning of "invalid fontweight structures" as referenced in this test, so I left it unchanged.
I would appreciate assistance with this part.