Open
Conversation
🦋 Changeset detectedLatest commit: 8189b2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
|
Contributor
|
Commit SHA:3a29827a5e457d4ddc47fab76ac6438917eb0ec6 Test coverage results 🧪
|
The AliasBadge component used `value || ''` which treated 0 as falsy, causing the tooltip to show an empty string instead of '0'. Changed to `value ?? ''` to only fall back for null/undefined. Fixes #3776 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
six7
force-pushed
the
fix/tooltip-zero-value
branch
from
1654bb3 to
8189b2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3776
When a token's resolved value is exactly
0, the tooltip's alias badge was showing a blank value instead of displaying "0".Root Cause
In
AliasBadge.tsx, the expressionvalue || ''was used to provide a fallback. Since0is falsy in JavaScript, this treated a valid value of0the same asnull/undefined, replacing it with an empty string.Fix
Changed
value || ''tovalue ?? ''(nullish coalescing), which only falls back to''fornullandundefined— not for0.Testing
0and an alias referencing them0is displayed in the tooltip