Add loading state to save button in Edit sync provider dialog#3642
Draft
Add loading state to save button in Edit sync provider dialog#3642
Conversation
🦋 Changeset detectedLatest commit: 32334a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: six7 <4548309+six7@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add loading prop to save button in edit sync provider dialog
Add loading state to save button in Edit sync provider dialog
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Edit sync provider dialog was missing a loading indicator on the save button during the async operation. When users clicked "Save", the plugin would:
However, there was no visual feedback during this process, leaving users uncertain whether their action was being processed.
Solution
Added loading state tracking to the
EditStorageItemModalcomponent that:isLoadingtotruewhen the save operation beginsStorageItemFormto all provider-specific form componentsloadingpropChanges
isLoadingstate management and error state reset on saveisLoadingprop that gets passed to all provider formsloading={isLoading}prop to submit buttonsResult
Users now see a loading indicator on the save button while the plugin is:
This provides clear visual feedback and prevents confusion about whether the save operation is in progress.
Testing
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.