Add download retries #198
Merged
Add download retries #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artek0chumak
approved these changes
Dec 15, 2025
timofeev1995
requested review from
timofeev1995
and removed request for
sadreamer
src/together/lib/constants.py
Outdated
| DOWNLOAD_BLOCK_SIZE = 10 * 1024 * 1024 # 10 MB | ||
| DISABLE_TQDM = False | ||
| MAX_DOWNLOAD_RETRIES = 5 # Maximum retries for download failures | ||
| DOWNLOAD_RETRY_DELAY = 1.0 # Initial retry delay in seconds |
There was a problem hiding this comment.
I'd name DOWNLOAD_INITIAL_RETRY_DELAY according to the comment for consistency
src/together/lib/resources/files.py
Outdated
| try: | ||
| # If this is a retry, close the previous response and create a new one with Range header | ||
| if bytes_downloaded > 0: | ||
| if 'response' in locals(): |
There was a problem hiding this comment.
Can we do
response = None above the with tqdm to avoid using "locals" doing if response is None instead?
timofeev1995
approved these changes
Dec 16, 2025
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 7. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
stainless-app bot
added a commit
that referenced
this pull request
Dec 16, 2025
* feat(api): api update * chore(internal): add missing files argument to base client * feat(api): api update * Add progress bar for Fine-tuning API (#197) Add progress bar for FT * Add download retries (#198) * add download retries * feat(files): add support for string alternative to file upload type * release: 2.0.0-alpha.11 --------- Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com> Co-authored-by: Artem Chumachenko <[email protected]> Co-authored-by: Ruslan Khaidurov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds retries for downloads, which is supposed to fix some issues with large files.