Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): extract markdown and mix-text adapter to shared #9383

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

donteatfriedrice
Copy link
Member

No description provided.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added test Related to test cases app:core labels Dec 27, 2024
@donteatfriedrice donteatfriedrice force-pushed the 12-27-refactor_editor_extract_markdown_and_mix-text_adapter_to_shared branch from 76bfdc6 to 78d82ff Compare December 27, 2024 09:45
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 72.91667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 51.50%. Comparing base (6da10f9) to head (feec85d).

Files with missing lines Patch % Lines
...ksuite/blocks/src/_common/transformers/markdown.ts 20.00% 4 Missing ⚠️
...ksuite/presets/_common/components/text-renderer.ts 0.00% 3 Missing ⚠️
blocksuite/affine/shared/src/adapters/mix-text.ts 33.33% 2 Missing ⚠️
...blocksuite/presets/_common/utils/markdown-utils.ts 0.00% 2 Missing ⚠️
...te/affine/shared/src/adapters/markdown/markdown.ts 83.33% 1 Missing ⚠️
.../src/blocksuite/presets/ai/utils/editor-actions.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9383      +/-   ##
==========================================
+ Coverage   51.44%   51.50%   +0.05%     
==========================================
  Files        2157     2158       +1     
  Lines       97660    97669       +9     
  Branches    16380    16378       -2     
==========================================
+ Hits        50244    50305      +61     
+ Misses      46030    45972      -58     
- Partials     1386     1392       +6     
Flag Coverage Δ
server-test 78.31% <ø> (+0.06%) ⬆️
unittest 31.08% <72.91%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donteatfriedrice donteatfriedrice force-pushed the 12-27-refactor_editor_extract_markdown_and_mix-text_adapter_to_shared branch from 78d82ff to feec85d Compare December 27, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant