Skip to content

Conversation

inesmaria08
Copy link
Contributor

@inesmaria08 inesmaria08 commented Feb 11, 2025

This pull request adds an interface for screen management.
It includes implementations and unit tests, and has been tested on a Raspberry Pi Pico using a Pico Explorer Base.

Files added:

  • unittest/src/fake/display/mod.rs
  • unittest/src/fake/display/tests.rs
  • examples/screen.rs
  • apis/interface/display/src/lib.rs
  • apis/interface/display/src/tests.rs

Tests:

  • Manually tested on a Raspberry Pi Pico with a Pico Explorer Base.
  • Unit tests added for both fake and real interfaces.

@inesmaria08 inesmaria08 marked this pull request as ready for review May 16, 2025 19:51
@alevy alevy self-assigned this Jun 4, 2025
@alexandruradovici
Copy link
Contributor

This seems to be a rust version problem, @inesmaria08 could you please rebase your branch and force push it?

@bradjc
Copy link
Contributor

bradjc commented Jul 28, 2025

I would like to try this out. It seems like it needs a rebase at this point. I was able to confirm that just including the relevant changes do work with the nrf52840dk (https://github.com/tock/libtock-rs/compare/display-bradjc?expand=1).

To merge this I think we should rename "display" to "screen" to be consistent with the kernel.

@bradjc
Copy link
Contributor

bradjc commented Jul 28, 2025

Any chance you have tried embedded graphics? https://crates.io/crates/embedded-graphics

@bradjc
Copy link
Contributor

bradjc commented Jul 28, 2025

To merge this I think we should rename "display" to "screen" to be consistent with the kernel.

The display crate should be renamed to screen and moved to a folder called display in the apis folder.

@JADarius
Copy link
Contributor

JADarius commented Aug 5, 2025

I tested this on a Pico Explorer Base with 2 Pico boards (Pico 1 and Pico 2). On the Pico 2 this works out of the box, but on the Pico 1 there is a strange bug. If I am using normal UART for debugging, it works out of the box, but when I use UART over USB, the screen gets stuck on the init and I have to reset the board from Process Console for it to work. I can't tell if this is an issue with the board, the Tock port or libtock-rs.

@bradjc
Copy link
Contributor

bradjc commented Aug 12, 2025

This looks good except for making the crate apis/display/screen so we can add other displays in the future.

@inesmaria08 inesmaria08 requested a review from bradjc August 14, 2025 07:21
@bradjc
Copy link
Contributor

bradjc commented Aug 22, 2025

@alexandruradovici can you review?

@alevy alevy dismissed alexandruradovici’s stale review August 27, 2025 18:12

stale review with addressed comments.

@alevy alevy added this pull request to the merge queue Aug 27, 2025
Merged via the queue into tock:master with commit 1a5b9b3 Aug 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants