Skip to content

Also consider RO data for start of flash #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Also consider RO data for start of flash #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/convert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,9 +351,9 @@ pub fn elf_to_tbf(
continue;
}

// Flash segments have to be marked executable, and we only care about
// Flash segments have to be marked read-only, and we only care about
// segments that actually contain data to be loaded into flash.
if (segment.p_flags & elf::abi::PF_X) > 0
if (segment.p_flags & elf::abi::PF_W) == 0
&& section_exists_in_segment(&elf_sections, segment)
{
// If this is standard Tock PIC, then this virtual address will be
Expand Down