Skip to content

Conversation

@vthemelis
Copy link
Contributor

This only really adds pyright to tox and ignores to everything that's flagged.

The ignores can be incrementally removed.

This only really adds pyright to tox and ignores to everything that's
flagged.

The ignores can be incrementally removed.
@vthemelis vthemelis mentioned this pull request Sep 28, 2025
@tobgu
Copy link
Owner

tobgu commented Oct 12, 2025

Thanks!

When adding # type: ignore[reportGeneralTypeIssues] like done in this PR, there is no risk that type checkers in editors start ignoring things they previously reported errors on?

What are the errors being reported, that we ignore?

@vthemelis
Copy link
Contributor Author

Hi @tobgu,

reportGeneralTypeIssues is a pyright error type. I'm just disabling it on lines that were flagged for now instead of fixing. I find that this is an easy way to incrementally add type checking into a project. You could fix the error when you're next in the area but in the meantime, pyright will avoid more type errors appearing in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants