Conversation
|
@copilot resolve the merge conflicts in this pull request |
There was a problem hiding this comment.
Pull request overview
This PR refines the Ghostel terminal backend integration so ai-code preserves Ghostel's native lifecycle (title tracking, kill-on-exit, sentinel) while still applying ai-code's session cleanup. It also routes resize handling through Ghostel's window-size adjuster and recognizes the newer ghostel--input-mode copy state.
Changes:
- Reapply
--configure-ghostel-bufferafterghostel-execso title tracking and kill-on-exit stay disabled, and capture Ghostel's native sentinel in a process property. - In
--finalize-started-session, chain any captured Ghostel sentinel before invoking ai-code cleanup. - Use Ghostel's
--window-adjust-process-window-sizefor sync, and treatghostel--input-mode = 'copyas navigation mode.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ai-code-backends-infra.el | Routes Ghostel resize through its native handler, chains a saved Ghostel sentinel before cleanup, plus docstring tweaks. |
| ai-code-backends-infra-ghostel.el | Reconfigures Ghostel buffer post-ghostel-exec, stashes native sentinel, adds ghostel--input-mode copy detection, disables ghostel-kill-buffer-on-exit. |
| test/test_ai-code-backends-infra.el | Adds regression coverage for resize routing, sentinel chaining/preservation, title tracking, and new copy-mode detection. |
Co-authored-by: tninja <714625+tninja@users.noreply.github.com>
Resolved the merge conflicts by merging |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0eb12d4bf8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: tninja <714625+tninja@users.noreply.github.com>
This improves the Ghostel terminal backend integration so ai-code preserves Ghostel's own process behavior while still applying ai-code session lifecycle handling.
The change keeps Ghostel title tracking and buffer-on-exit behavior disabled after
ghostel-exec, preserves and chains Ghostel's native process sentinel before ai-code cleanup, and routes Ghostel resize handling through Ghostel's own window-size adjustment path. It also treats newer Ghostelghostel--input-modecopy state as terminal navigation mode while keeping the olderghostel--copy-mode-activepath compatible.The vterm and eat backends are not changed. I verified the backend dispatch paths with targeted vterm/eat tests and runtime probes, and added Ghostel regression coverage for resize handling, sentinel chaining, title tracking, and copy-mode detection.
Verification:
emacs -Q -batch -L . --eval "(setq load-prefer-newer t)" -l ert -l test/test_ai-code-backends-infra.el -f ert-run-tests-batch-and-exitemacs -Q -batch -L . -l ert --eval "(mapc #'load-file (file-expand-wildcards \"test/test_*.el\"))" -f ert-run-tests-batch-and-exitemacs -Q -batch -L . --eval "(setq load-prefer-newer t)" -f batch-byte-compile ai-code-backends-infra.el ai-code-backends-infra-vterm.el ai-code-backends-infra-eat.el ai-code-backends-infra-ghostel.elgit diff --check