Anaconda Installation Instructions and Bug Fix #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnakazato
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Hi @iganay958,
Thank you for your contribution! I've put a few review comments. I would appreciate it if you could address them.
tnakazato
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Anaconda Installation Instructions (Install-Anaconda.md).
Some Bug fix:
2.1 In imager.py, around line 740 and 770, the original codes caused assertion errors on my device, which is due to floating point precision problem (e.g., 0.1 vs 0.099999999999). I resolved it by using
np.isclose()instead of direct comparison.2.2 In setup.py, add some lines to help detailed configure information of lib names and paths, which may help future debug.
2.3 Update the URL of HL Tau file in the tutorial, the original one is not available now.