Skip to content

browser bench fixes #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2025
Merged

browser bench fixes #821

merged 5 commits into from
May 8, 2025

Conversation

themighty1
Copy link
Member

This PR adds changes to the browser bench crate to make it run again.

The benches were run successfully in gh actions multiple times https://github.com/tlsnotary/tlsn/actions/workflows/bench.yml

@themighty1 themighty1 requested a review from heeckhau May 5, 2025 07:18
Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but I expect we want to run the benches in release mode

@themighty1 themighty1 requested a review from heeckhau May 7, 2025 06:17
@themighty1 themighty1 merged commit 3b5ac20 into dev May 8, 2025
16 checks passed
@themighty1 themighty1 deleted the browser_bench_fixes branch May 8, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants