Skip to content

feat(deap): address space mapping #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feat/prf-local
Choose a base branch
from

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Apr 23, 2025

This PR adds address space mapping to DEAP so that the MPC and ZK memories do not have to be synchronized. This allows us to dynamically allocate freely.

@sinui0 sinui0 requested review from themighty1 and th4s April 23, 2025 23:37
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some comments/questions.

@sinui0
Copy link
Member Author

sinui0 commented Apr 29, 2025

Ouch, just remembered we assume contiguous memory allocations in the cipher crate. That will have to be resolved before we can merge this.

@sinui0 sinui0 force-pushed the refactor/deap-memory branch from 8f5ee7b to 0eb1158 Compare May 1, 2025 18:49
@th4s th4s force-pushed the feat/prf-local branch 2 times, most recently from 0a371e9 to 78a51b1 Compare May 7, 2025 11:26
@sinui0 sinui0 force-pushed the refactor/deap-memory branch from 0eb1158 to 7a49db3 Compare May 7, 2025 11:48
@sinui0 sinui0 force-pushed the refactor/deap-memory branch from 7a49db3 to 65c68cd Compare May 8, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants