Skip to content

feat(prf): reduced MPC variant #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 35 commits into
base: chore/bump-mpz-alpha.3
Choose a base branch
from
Open

feat(prf): reduced MPC variant #735

wants to merge 35 commits into from

Conversation

th4s
Copy link
Member

@th4s th4s commented Mar 19, 2025 •
edited
Loading

This PR

  • provides an improved api for SHA256 and HMAC circuits using the new VM approach.
  • reduces the memory foot print of the PRF circuits by not building the whole PRF circuit at compile time.
  • adapts the old PRF implementation.
  • adds a new prf variant to compute parts of the PRF locally, reducing bandwidth at the cost of roundtrips.
  • expose the choice which variant to use via a config to mpc-tls, prover, verifier crates.

@th4s th4s force-pushed the chore/bump-mpz-alpha.3 branch from 56e9e48 to a90e402 Compare March 20, 2025 14:45
@th4s th4s force-pushed the feat/prf-local branch 3 times, most recently from c5b413a to 860a1e5 Compare March 21, 2025 14:56
@th4s th4s linked an issue Mar 24, 2025 that may be closed by this pull request
perf: Implement PRF optimization #728
Open
@th4s th4s force-pushed the chore/bump-mpz-alpha.3 branch from f584ce6 to 2e47bb6 Compare March 24, 2025 11:22
@th4s th4s marked this pull request as ready for review March 25, 2025 12:22
@th4s th4s force-pushed the chore/bump-mpz-alpha.3 branch from 2e47bb6 to bed4d48 Compare March 26, 2025 07:43
@th4s th4s force-pushed the chore/bump-mpz-alpha.3 branch 2 times, most recently from 923589f to 91dccd2 Compare March 26, 2025 19:12
@th4s th4s force-pushed the chore/bump-mpz-alpha.3 branch from 0f04b81 to be27c70 Compare March 28, 2025 11:08
@th4s th4s requested a review from sinui0 March 28, 2025 12:50
@th4s th4s force-pushed the chore/bump-mpz-alpha.3 branch from be27c70 to 91e47c7 Compare April 11, 2025 13:32
@sinui0 sinui0 force-pushed the chore/bump-mpz-alpha.3 branch 2 times, most recently from 9d1eb30 to 24005e4 Compare April 23, 2025 14:22
th4s added 22 commits May 7, 2025 13:20
@th4s
improved inner control flow for normal prf version
97e12eb
@th4s
rename leftover config -> mode
1a17be1
@th4s
remove unnecessary pub(crate)
59314fb
@th4s
rewrite state flow for reduced prf
1d28c5e
@th4s
improve state transition for reduced prf
7f86206
@th4s
repair prf bench
079f122
@th4s
WIP: Adapting to new Sha256 from mpz
ea3e164
@th4s
repair failing test
671ff38
@th4s
fixed all tests
2efb226
@th4s
remove output decoding for p
4504099
@th4s
do not use mod.rs file hierarchy
d015704
@th4s
remove pub(crate) from function
ea874a8
@th4s
improve config handling
93bb180
@th4s
use Array::try_from
33f7aa3
@th4s
simplify hmac to function
1366dbe
@th4s
remove merge_vecs
ad1d10a
@th4s
move mark_public to allocation
077c704
@th4s
minor fixes
93f4a08
@th4s
simplify state logic for reduced prf even more
3ce2dff
@th4s
simplify reduced prf even more
2724c89
@th4s
set reduced prf as default
b4f5d03
@th4s
temporarily fix commit for mpz
78a51b1
@th4s th4s force-pushed the feat/prf-local branch from 0a371e9 to 78a51b1 Compare May 7, 2025 11:26
sinui0
sinui0 approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l g t m

@th4s th4s requested a review from themighty1 May 7, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinui0 sinui0 sinui0 approved these changes

@themighty1 themighty1 Awaiting requested review from themighty1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perf: Implement PRF optimization
2 participants
@th4s @sinui0