feat(cipher): use AES pre/post key schedule circuits #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinui0
requested changes
Nov 5, 2025
| use error::ErrorKind; | ||
|
|
||
| /// AES key schedule: 11 round keys, 16 bytes each. | ||
| type KeyShedule = Array<U8, 176>; |
There was a problem hiding this comment.
Suggested change
| type KeyShedule = Array<U8, 176>; | |
| type KeySchedule = Array<U8, 176>; |
|
|
||
| let ks = *self | ||
| .key_schedule | ||
| .get_or_insert(self.alloc_key_schedule(vm)?); |
There was a problem hiding this comment.
get_or_insert evaluates eagerly, so self.alloc_key_schedule(vm)? is going to be called on every call to alloc_block
|
|
||
| let ks = *self | ||
| .key_schedule | ||
| .get_or_insert(self.alloc_key_schedule(vm)?); |
| .map(|(explicit_nonce, counter)| { | ||
| let ks = *self | ||
| .key_schedule | ||
| .get_or_insert(self.alloc_key_schedule(vm)?); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes advantage of the recently added AES pre/post key schedule circuits in
mpzand integrates them into theciphercrate.