Implement sans-io api #1036
Open
Implement sans-io api #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th4s
force-pushed
the
refactor/add-tls-client-trait
branch
from
971e793 to
80d2fa8
Compare
th4s
force-pushed
the
refactor/sans-io-tls-client
branch
from
a8b5192 to
ca8403a
Compare
th4s
force-pushed
the
refactor/add-tls-client-trait
branch
from
80d2fa8 to
f808fb4
Compare
Member
Author
|
@sinui0 I think you can take a look :) |
sinui0
requested changes
Oct 30, 2025
Member
sinui0
left a comment
sinui0
left a comment
There was a problem hiding this comment.
Didnt get time to finish but posting this partial review
sinui0
reviewed
Nov 4, 2025
th4s
force-pushed
the
refactor/sans-io-tls-client
branch
from
ca8403a to
dba3fdf
Compare
th4s
force-pushed
the
refactor/add-tls-client-trait
branch
from
e978c4f to
9fe7b09
Compare
sinui0
reviewed
Nov 12, 2025
Member
There was a problem hiding this comment.
It seems to me that we can flatten all the state into a single enum (State) instead of having what is right now an M x N x O state space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sans-io api for our prover in the form of a new prover state
Prover<Connected>.