Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR] Add 'None' loop support in 'decompose_reduction' #263

Conversation

MasterJH5574
Copy link
Collaborator

@spectrometerHBH Could you help review the code? If it is right, we can get it merged.

@MasterJH5574
Copy link
Collaborator Author

idk why the changes in GitHub look so complicated...
After all, the main change is in https://github.com/Hzfengsy/tvm-tensorir/blob/f7bd17e40ba7a84cceebd7cb640ccf4c99268682/src/tir/schedule/schedule_reduction.cc#L190-L219.

Copy link
Collaborator

@spectrometerHBH spectrometerHBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged if add a testcase

@MasterJH5574 MasterJH5574 merged commit bd96640 into tlc-pack:master Feb 4, 2021
@MasterJH5574
Copy link
Collaborator Author

Thanks @spectrometerHBH for the review!

Hzfengsy pushed a commit that referenced this pull request Feb 20, 2021
* [TIR] Add 'None' loop support in 'decompose_reduction'

* [TIR] Add simplification and a unit test
Hzfengsy pushed a commit that referenced this pull request Mar 29, 2021
* [TIR] Add 'None' loop support in 'decompose_reduction'

* [TIR] Add simplification and a unit test
Hzfengsy pushed a commit that referenced this pull request May 24, 2021
* [TIR] Add 'None' loop support in 'decompose_reduction'

* [TIR] Add simplification and a unit test
Hzfengsy pushed a commit that referenced this pull request Jul 5, 2021
* [TIR] Add 'None' loop support in 'decompose_reduction'

* [TIR] Add simplification and a unit test
jinhongyii pushed a commit that referenced this pull request Jul 29, 2021
* [TIR] Add 'None' loop support in 'decompose_reduction'

* [TIR] Add simplification and a unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants