Skip to content

Commit

Permalink
Merge pull request TheOdinProject#326 from christinamakes/text_visibi…
Browse files Browse the repository at this point in the history
…lity_updates

css-exercises: color contrast updates for WCAG compliance
  • Loading branch information
codyloyd authored Jun 12, 2023
2 parents 4eea74d + 3c9fe0e commit a578b25
Show file tree
Hide file tree
Showing 14 changed files with 49 additions and 44 deletions.
Binary file modified foundations/05-descendant-combinator/desired-outcome.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions foundations/05-descendant-combinator/solution/solution.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.container .text {
background-color: yellow;
color: red;
color: #E00000;
font-size: 20px;
text-align: center;
}
Expand All @@ -11,4 +11,4 @@ div p
div .text
.container p
*/
*/
Binary file modified grid/01-grid-layout-1/desired-outcome.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 11 additions & 10 deletions grid/01-grid-layout-1/solution/solution.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
body, html {
body,
html {
height: 100%;
margin: 0;
}
Expand All @@ -20,19 +21,23 @@ body, html {
}

.header {
background-color: #FFDE22;
background-color: #006157
}

.sidebar {
background-color: #FF7755;
background-color: #005B94
}

.nav {
background-color: #00DDFF;
background-color: #642cde
}

.article {
background-color: #bccbde;
background-color: #7E1DC3
}

.footer {
background-color: #393f4d;
}

.article p {
Expand All @@ -42,10 +47,6 @@ body, html {
text-align: left;
}

.footer {
background-color: #393f4d;
}

/* SOLUTION */

.container {
Expand All @@ -65,4 +66,4 @@ body, html {

.footer {
grid-column: 1 / 3;
}
}
21 changes: 11 additions & 10 deletions grid/01-grid-layout-1/style.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
body, html {
body,
html {
height: 100%;
margin: 0;
}
Expand All @@ -20,28 +21,28 @@ body, html {
}

.header {
background-color: #FFDE22;
background-color: #006157;
}

.sidebar {
background-color: #FF7755;
background-color: #005B94;
}

.nav {
background-color: #00DDFF;
background-color: #642cde;
}

.article {
background-color: #bccbde;
background-color: #7E1DC3;
}

.footer {
background-color: #393f4d;
}

.article p {
font-size: 18px;
font-family: sans-serif;
color: white;
text-align: left;
}

.footer {
background-color: #393f4d;
}
}
Binary file modified grid/02-grid-layout-2/desired-outcome-narrow.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified grid/02-grid-layout-2/desired-outcome-wide.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 7 additions & 6 deletions grid/02-grid-layout-2/solution/solution.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
body, html {
body,
html {
height: 100%;
margin: 0;
}
Expand All @@ -20,21 +21,21 @@ body, html {
}

.header {
background-color: #FFDE22;
background-color: #006157;
grid-column: 1 / 3;
}

.sidebar {
background-color: #FF7755;
background-color: #005B94;
grid-row: 2 / 4;
}

.nav {
background-color: #00DDFF;
background-color: #642cde;
}

.article {
background-color: #bccbde;
background-color: #7E1DC3;
}

.article p {
Expand All @@ -56,4 +57,4 @@ body, html {
grid-template-columns: 1fr 3fr;
grid-template-rows: 1fr 1fr 5fr 1fr;
gap: 15px;
}
}
13 changes: 7 additions & 6 deletions grid/02-grid-layout-2/style.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
body, html {
body,
html {
height: 100%;
margin: 0;
}
Expand All @@ -20,21 +21,21 @@ body, html {
}

.header {
background-color: #FFDE22;
background-color: #006157;
grid-column: 1 / 3;
}

.sidebar {
background-color: #FF7755;
background-color: #005B94;
grid-row: 2 / 4;
}

.nav {
background-color: #00DDFF;
background-color: #642cde;
}

.article {
background-color: #bccbde;
background-color: #7E1DC3;
}

.article p {
Expand All @@ -47,4 +48,4 @@ body, html {
.footer {
background-color: #393f4d;
grid-column: 1 / 3;
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed grid/03-grid-layout-3/desired-outcome-stretched.png
Binary file not shown.
Binary file modified grid/03-grid-layout-3/desired-outcome.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 7 additions & 6 deletions grid/03-grid-layout-3/solution/solution.css
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
}

.sidebar {
background-color: #FF7755;
background-color: #C50208;
}

.sidebar .photo {
Expand All @@ -46,7 +46,7 @@
}

.nav {
background-color: #FF7755;
background-color: #C50208;
}


Expand Down Expand Up @@ -89,7 +89,7 @@

.footer p {
font-size: 13px;
font-weight: normal;
font-weight: normal;
}

/* SOLUTION */
Expand Down Expand Up @@ -130,8 +130,9 @@
gap: 50px;
}

.side-content, .photo {
display: grid;
.side-content,
.photo {
display: grid;
align-items: center;
}

Expand All @@ -157,4 +158,4 @@

.footer {
grid-column: 1 / 3;
}
}
8 changes: 4 additions & 4 deletions grid/03-grid-layout-3/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
}

.sidebar {
background-color: #FF7755;
background-color: #C50208;
}

.sidebar .photo {
Expand All @@ -45,7 +45,7 @@
}

.nav {
background-color: #FF7755;
background-color: #C50208;
}

.nav ul li {
Expand Down Expand Up @@ -87,5 +87,5 @@

.footer p {
font-size: 13px;
font-weight: normal;
}
font-weight: normal;
}

0 comments on commit a578b25

Please sign in to comment.