Skip to content

Add @turnkey/sdk-types package #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

turnekybc
Copy link
Contributor

@turnekybc turnekybc commented Apr 8, 2025

Summary & Motivation

  • scaffold @turnkey/sdk-types for re-usable typings

How I Tested These Changes

  • added @turnkey/sdk-types as a dependency to @turnkey/sdk-react
{
  "name": "@turnkey/sdk-react",
  "version": "4.2.1",
  ...
  "dependencies": {
    ...
    "@turnkey/crypto": "workspace:*",
    "@turnkey/sdk-browser": "workspace:*",
    "@turnkey/sdk-server": "workspace:*",
    "@turnkey/wallet-stamper": "workspace:*",
    "@turnkey/sdk-types": "workspace:*",
    ...
  },
}

  • pnpm install -r
  • pnpm run build-all
  • removed SessionType enum declaration in packages/sdk-react/src/components/auth/Auth.tsx
  • import { SessionType } from "@turnkey/sdk-types";
  • tested examples/react-components locally

Did you add a changeset?

If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run pnpm changeset. pnpm changeset will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).

These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.

Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sdk-email-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 7:41pm
sdk-otp-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 7:41pm

Copy link

codesandbox-ci bot commented Apr 8, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5cc101b:

Sandbox Source
@turnkey/example-react-components Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant