add request ids to iframe stamper #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkmin
commented
Jan 7, 2025
| } | ||
|
|
||
| function generateUUID(): string { | ||
| return crypto.randomUUID(); |
There was a problem hiding this comment.
The iframe stamper will be used strictly in the web browser context, so crypto should be an available resource. randomUUID is pretty readily available for most modern web browsers.
If we're worried about compatibility, there's an implementation that relies on the older getRandomValues (see https://stackoverflow.com/a/2117523)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
andrewkmin
force-pushed
the
andrew/iframe-idempotency
branch
from
7868a19 to
fa1f11c
Compare
andrewkmin
force-pushed
the
andrew/iframe-idempotency
branch
from
fa1f11c to
dbe3d37
Compare
r-n-o
approved these changes
Jan 23, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
$title
iframe counterpart: tkhq/frames#59
This mainly serves the case where there are concurrent, or serial, requests. Request IDs are used to disambiguate between multiple requests.
Latency implications: roughly ~4 seconds for 100 parallel signing requests, compared to ~0.7 seconds if signing 100 payloads using an im-memory API key stamper. The difference comes in overhead cost of the iframe communications.
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.