Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a1fab82:
|
f5c6d82 to
19f37a1
Compare
There was a problem hiding this comment.
Pull request overview
Monorepo release sync for v2026.2.8, updating generated SDK surface areas to reflect the latest Public API/Auth Proxy swagger changes—most notably the new encrypted OTP flow and newly versioned OTP-related activity types.
Changes:
- Version OTP activities and update generated clients/types to use
*_V2/*_V3activity types and new OTP request/response shapes (encrypted bundles + required client signature). - Extend API/type definitions (e.g., asset metadata
name, supported CAIP-2 enums, TVC deployment spec changes, auth proxy additions likesocialLinkingClientIds). - Regenerate swagger/type artifacts across
sdk-types,sdk-server,sdk-browser,core, andhttp.
Reviewed changes
Copilot reviewed 17 out of 29 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Sync pnpm override formatting for rollup. |
| package.json | Sync pnpm override formatting for rollup. |
| .changeset/short-bars-worry.md | Release notes/changeset for v2026.2.8 features and versioned OTP activities. |
| packages/sdk-types/src/inputs/public_api.types.ts | Updates public API type inputs (OTP v2/v3, asset metadata, CAIP-2 enums, TVC changes). |
| packages/sdk-types/src/inputs/public_api.swagger.json | Updates public API swagger inputs (OTP v2/v3, asset metadata, CAIP-2 enums, TVC changes). |
| packages/sdk-types/src/inputs/auth_proxy.swagger.json | Adds auth-proxy OTP v2 endpoints/types. |
| packages/sdk-types/src/generated/types.ts | Regenerated SDK types to match updated inputs (OTP encryption/signature requirements, etc.). |
| packages/sdk-types/scripts/codegen.js | Codegen mapping extended for new versioned OTP activity types. |
| packages/sdk-server/src/inputs/public_api.types.ts | Server SDK input types synced to updated public API. |
| packages/sdk-server/src/inputs/public_api.swagger.json | Server SDK swagger inputs synced to updated public API. |
| packages/sdk-server/src/generated/sdk_api_types.ts | Server SDK API types regenerated for new initOtp result key. |
| packages/sdk-server/src/generated/sdk-client-base.ts | Server SDK client regenerated to submit versioned OTP activity types / result keys. |
| packages/sdk-server/scripts/codegen.js | Server codegen updated to map OTP activities to latest versions. |
| packages/sdk-browser/src/inputs/public_api.types.ts | Browser SDK input types synced to updated public API. |
| packages/sdk-browser/src/inputs/public_api.swagger.json | Browser SDK swagger inputs synced to updated public API. |
| packages/sdk-browser/src/generated/sdk_api_types.ts | Browser SDK API types regenerated for new initOtp result key. |
| packages/sdk-browser/src/generated/sdk-client-base.ts | Browser SDK client regenerated to submit versioned OTP activity types / result keys. |
| packages/sdk-browser/scripts/codegen.js | Browser codegen updated to map OTP activities to latest versions. |
| packages/sdk-browser/CHANGELOG.md | Fixes changelog entry typo for ACTIVITY_TYPE_INIT_OTP_AUTH. |
| packages/http/src/generated/services/coordinator/public/v1/public_api.* | Regenerated HTTP client artifacts to match updated public API swagger/types. |
| packages/http/CHANGELOG.md | Fixes changelog entry typo for ACTIVITY_TYPE_INIT_OTP_AUTH. |
| packages/core/src/inputs/public_api.swagger.json | Core swagger inputs synced to updated public API. |
| packages/core/src/inputs/auth_proxy.swagger.json | Adds auth-proxy OTP v2 endpoints/types in core inputs. |
| packages/core/src/generated/sdk-client-base.ts | Core client partially updated (initOtp + new auth-proxy v2 methods). |
| packages/core/scripts/codegen.js | Core codegen partially updated for INIT_OTP (missing other OTP mappings). |
| packages/core/CHANGELOG.md | Fixes changelog entry typo for ACTIVITY_TYPE_INIT_OTP_AUTH. |
Files not reviewed (10)
- packages/core/src/generated/sdk-client-base.ts: Language not supported
- packages/http/src/generated/services/coordinator/public/v1/public_api.client.ts: Language not supported
- packages/http/src/generated/services/coordinator/public/v1/public_api.fetcher.ts: Language not supported
- packages/http/src/generated/services/coordinator/public/v1/public_api.swagger.json: Language not supported
- packages/http/src/generated/services/coordinator/public/v1/public_api.types.ts: Language not supported
- packages/sdk-browser/src/generated/sdk-client-base.ts: Language not supported
- packages/sdk-browser/src/generated/sdk_api_types.ts: Language not supported
- packages/sdk-server/src/generated/sdk-client-base.ts: Language not supported
- packages/sdk-server/src/generated/sdk_api_types.ts: Language not supported
- packages/sdk-types/src/generated/types.ts: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "description": "Enum to specifiy whether to send OTP code via SMS or email" | ||
| }, |
There was a problem hiding this comment.
Typo in description: "specifiy" → "specify".
There was a problem hiding this comment.
going to be taken care of in a followup
| "description": "Enum to specifiy whether to send OTP code via SMS or email" | ||
| }, |
There was a problem hiding this comment.
Typo in description: "specifiy" → "specify".
| "ACTIVITY_TYPE_INIT_OTP_V3", | ||
| "v1InitOtpIntentV3", | ||
| "v1InitOtpResultV2", | ||
| ], |
There was a problem hiding this comment.
VERSIONED_ACTIVITY_TYPES was updated for INIT_OTP but is missing entries for the newly versioned OTP activities (VERIFY_OTP and OTP_LOGIN). Because core’s codegen relies on this map to rewrite activity type strings and result keys, leaving these out will keep generating ACTIVITY_TYPE_VERIFY_OTP/ACTIVITY_TYPE_OTP_LOGIN in the core SDK client, which no longer matches the v2 activity types introduced in this release. Add mappings for VERIFY_OTP → VERIFY_OTP_V2 (intent v1VerifyOtpIntentV2, result v1VerifyOtpResult) and OTP_LOGIN → OTP_LOGIN_V2 (intent v1OtpLoginIntentV2, result v1OtpLoginResult), then regenerate.
| ], | |
| ], | |
| ACTIVITY_TYPE_VERIFY_OTP: [ | |
| "ACTIVITY_TYPE_VERIFY_OTP_V2", | |
| "v1VerifyOtpIntentV2", | |
| "v1VerifyOtpResult", | |
| ], | |
| ACTIVITY_TYPE_OTP_LOGIN: [ | |
| "ACTIVITY_TYPE_OTP_LOGIN_V2", | |
| "v1OtpLoginIntentV2", | |
| "v1OtpLoginResult", | |
| ], |
| timestampMs: timestampMs ?? String(Date.now()), | ||
| type: "ACTIVITY_TYPE_INIT_OTP_V2", | ||
| type: "ACTIVITY_TYPE_INIT_OTP_V3", | ||
| }, | ||
| "initOtpResult", | ||
| "initOtpResultV2", | ||
| stampWith, |
There was a problem hiding this comment.
Core SDK initOtp has been moved to ACTIVITY_TYPE_INIT_OTP_V3 / initOtpResultV2, but this file still contains otpLogin and verifyOtp methods that submit ACTIVITY_TYPE_OTP_LOGIN and ACTIVITY_TYPE_VERIFY_OTP (unversioned). With this release introducing ACTIVITY_TYPE_OTP_LOGIN_V2 and ACTIVITY_TYPE_VERIFY_OTP_V2 (and changing their parameter shapes), these older activity types are likely to be rejected or behave incorrectly. Regenerate this client after adding the missing VERSIONED_ACTIVITY_TYPES mappings, or update the affected methods to use the v2 activity types and new parameter/result shapes.
.changeset/short-bars-worry.md
Outdated
| @@ -0,0 +1,19 @@ | |||
| --- | |||
| "@turnkey/sdk-browser": minor | |||
| "@turnkey/sdk-server": minor | |||
There was a problem hiding this comment.
Isn't this version bump a breaking change. sdk-server/browser will need major bumps I believe
7eeb0d2 to
722bf41
Compare
722bf41 to
c81eda7
Compare
c81eda7 to
a1fab82
Compare
Summary & Motivation
$title
How I Tested These Changes
Did you add a changeset?
yes
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.