Skip to content

added with-react-native-wallet-kit to our pnpm workspace#1205

Open
ethankonk wants to merge 3 commits intomainfrom
ethan/add-react-native-wallet-kit-demo-to-workspace
Open

added with-react-native-wallet-kit to our pnpm workspace#1205
ethankonk wants to merge 3 commits intomainfrom
ethan/add-react-native-wallet-kit-demo-to-workspace

Conversation

@ethankonk
Copy link
Contributor

Summary & Motivation

  • The react native demo app was previously excluded from our workspace since it wouldn't bundle, in order to fix this, I've changed pnpm's dependency installation strategy from isolated (default) to hoisted.

    • Default (isolated): pnpm uses a content-addressable store with symlinks. Each package only "sees" dependencies it explicitly declares in its own package.json. This is stricter and prevents phantom dependencies.
    • Hoisted: pnpm installs dependencies in a flat node_modules tree, similar to how npm works. All packages are hoisted to the root.
  • React Native's Metro bundler doesn't work well with pnpm's symlink-based isolation. Metro can't follow symlinks reliably, and native module autolinking expects a flat node_modules structure. Without hoisting, the RN example app fails to resolve dependencies at build time.

How I Tested These Changes

  • Locally

Did you add a changeset?

No need

@socket-security
Copy link

socket-security bot commented Feb 18, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedexpo-status-bar@​3.0.97310082100100
Addedexpo-image@​3.0.11781009199100
Addedexpo-system-ui@​6.0.910010078100100
Addedexpo-symbols@​1.0.810010081100100
Addedexpo-haptics@​15.0.810010084100100
Addedexpo-web-browser@​15.0.1010010085100100
Addedexpo-splash-screen@​31.0.13100100100100100

View full report

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 18, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c79f431:

Sandbox Source
@turnkey/example-react-components Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant