added with-react-native-wallet-kit to our pnpm workspace#1205
Open
added with-react-native-wallet-kit to our pnpm workspace#1205
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c79f431:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The react native demo app was previously excluded from our workspace since it wouldn't bundle, in order to fix this, I've changed pnpm's dependency installation strategy from isolated (default) to hoisted.
React Native's Metro bundler doesn't work well with pnpm's symlink-based isolation. Metro can't follow symlinks reliably, and native module autolinking expects a flat node_modules structure. Without hoisting, the RN example app fails to resolve dependencies at build time.
How I Tested These Changes
Did you add a changeset?
No need