Skip to content

assign 1 Float Tutorial #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

dpammyb
Copy link

@dpammyb dpammyb commented Oct 3, 2017

Changed a tag to flaot property

@titaniumbones
Copy link
Owner

Hi Diane,

As it stands the tutorial doesn't seem to work, I think because your css selector doens't address the image!

also --maybe your tutorial can give a few more hints about what specific steps the user should attempt in order to get the desired effect?

@dpammyb
Copy link
Author

dpammyb commented Oct 5, 2017

I will work to fix it. I ran it several times before I submitted it and it worked.
Re: specific steps, I was not sure how much detail to put. I felt I needed to address containers and margins and padding but then thought it would look like a toutorial about a few things instead of one. I should have checked with you. Thanks for the feed back.
Please clarify: Are you are giving me the opportunity to fix this or are you just explaining why I failed this assignment?

@titaniumbones
Copy link
Owner

titaniumbones commented Oct 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants