feat: Support generic types #410
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for generic types.
Say you have
type Foo[T any] struct
, you must add a constraint that it can be handled properly. The constraint is added with a built-intype Foo[T any, _ msgp.RTFor[T]
.If
T
supports serialization this will work. Multiple types can be added, but each must have the constraint.Nested of types are supported. For example:
Notice how
P
can be used for a nested generic type.Limitations
type Int64 int
with generation should still workmsgp.RTFor[T]
type shouldn't be used for types in the struct since new instances cannot be created and can cause a runtime crash.warn: generics.go: GenericTest: A: possible non-local identifier: T
.Example