Repository navigation
feat(render): compact search results and bounded page contents #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| //! Knobs for [`render_text_with`](super::render_text_with) and | ||
| //! [`render_markdown_with`](super::render_markdown_with). | ||
|
|
||
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| /// Snippets in rendered output are capped at this many characters. | ||
| pub const TEXT_EXCERPT_CHARS: usize = 500; | ||
|
|
||
| /// Per-page character cap [`RenderOptions::compact`] uses for page contents. | ||
| pub const COMPACT_CONTENTS_CHARS: usize = 1_500; | ||
|
|
||
| /// How much a rendering shows. [`Default`] is the original output: every | ||
| /// citation listed under `Sources`, snippets cut at [`TEXT_EXCERPT_CHARS`]. | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] | ||
| #[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))] | ||
| #[serde(default)] | ||
| pub struct RenderOptions { | ||
| /// Cap, in characters, on each result's snippet. | ||
| pub excerpt_chars: usize, | ||
| /// Cap, in characters, on each page's text in a page-contents response. | ||
| pub contents_chars: usize, | ||
| /// Leave out citations that repeat a listed result, and show at most | ||
| /// `max_results` of the rest. | ||
| pub compact_sources: bool, | ||
| } | ||
|
|
||
| impl Default for RenderOptions { | ||
| fn default() -> Self { | ||
| Self { | ||
| excerpt_chars: TEXT_EXCERPT_CHARS, | ||
| contents_chars: TEXT_EXCERPT_CHARS, | ||
| compact_sources: false, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl RenderOptions { | ||
| /// The compact rendering: no repeated sources and | ||
| /// [`COMPACT_CONTENTS_CHARS`] per page. | ||
| #[must_use] | ||
| pub const fn compact() -> Self { | ||
| Self { | ||
| excerpt_chars: TEXT_EXCERPT_CHARS, | ||
| contents_chars: COMPACT_CONTENTS_CHARS, | ||
| compact_sources: true, | ||
| } | ||
| } | ||
|
|
||
| /// The snippet cap for a response of `role`. | ||
| pub(super) const fn excerpt_for(&self, role: Option<crate::Role>) -> usize { | ||
| match role { | ||
| Some(crate::Role::Contents) => self.contents_chars, | ||
| _ => self.excerpt_chars, | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.