Skip to content

build: tinybus by version range + [patch.crates-io], submodule to 0.1.5 - #26

Merged
senamakel merged 1 commit into
mainfrom
tinybus-align
Oct 13, 2026
Merged

senamakel merged 1 commit into
mainfrom
tinybus-align

Conversation

@senamakel

Copy link
Copy Markdown
Member

Part of tinyhumansai/openhuman#7610, #7543, #7523

The tinybus, tinybus-macros, and tinybus-module dependencies now resolve
by version range instead of a pinned path, and a [patch.crates-io] table
points them at the vendored submodule. This lets a host workspace unify
every module on a single copy through its own patch while standalone
builds keep using the pinned submodule.

Auto-committed-on: dragonfly
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T17:51:25.263704Z 877c4a3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 32cd87a7-0c58-4940-b547-7f89312a3e23
📥 Commits

Reviewing files that changed from the base of the PR and between 16f9dbb and 877c4a3.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • vendor/tinybus
 _______________________________________________________
< Once upon a dream, I found all the bugs in your code. >
 -------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel merged commit 42212a6 into main Oct 13, 2026
13 of 14 checks passed
@tinysweeper

tinysweeper Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: low
Reviewed head: 877c4a392f7e
Updated: 2026-10-13T23:21:54Z

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: This change converts the `tinybus` and `tinybus-module` dependencies from explicit `path` + `version = "0.1.4"` entries to version-range requirements (`>=0.1.3, <0.2`), backed by a new `[patch.crates-io]` table pointing at the same submodule sources. The ranges are satisfiable (0.1.4 satisfies both), the patches keep standalone builds resolving against the pinned submodule, and the repo rule to keep `vendor/tinybus` pinned as a submodule is preserved rather than violated. I could not read the submodule's own manifests (the deployment cannot read anything under `vendor/tinybus`), so I cannot confirm that the `tinybus-macros` package name and path used in the new patch entry match the submodule's actual crate layout; that is the one detail to double-check before merging, since a wrong path there makes the patch entry fail to resolve. _The code index is behind this pull request (indexed at `f17a2f78ece7`), so retrieved context may be out of date._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: This change swaps the workspace's pinned path dependencies on `tinybus`/`tinybus-module` for crates.io version ranges and adds a `[patch.crates-io]` block that re-pins them to the same vendored submodule paths. The patch keeps standalone builds resolving to the vendored checkout, so the change is a packaging/resolution adjustment rather than a code change, and I found no reportable defect in it. One thing I could not verify from here: the deployment cannot read `vendor/tinybus`, so whether the submodule's manifests define the `tinybus-macros` package named in the patch table (a missing patch target is an error at resolution time) is outside what I was shown — but that is not evidence of a defect in this diff, and a scanner or CI would surface it. _The code index is behind this pull request (indexed at `f17a2f78ece7`), so retrieved context may be out of date._

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change swaps the path+version pins for version ranges on tinybus/tinybus-module and adds a [patch.crates-io] table pointing at the pinned submodule, which matches the stated intent of letting a host workspace unify on one copy. The PR body is a bare list of issue links and never mentions the submodule, so the description does not cover what the diff does. The tinysearch-bus crate remains free of tinybus and the submodule stays pinned, so no AGENTS.md rule is broken. _The code index is behind this pull request (indexed at `f17a2f78ece7`), so retrieved context may be out of date._
Evidence and run details
  • Models: ladder/vectors-oai3, deepseek-v4.1-flash
  • Spend: $0.000388
  • Tokens: 101415 input · 5330 output · 28416 cached · 85 embedding
Head State Pass summary
877c4a392f7e ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-10-13T23:21:54Z)

tinysweeper 0.1.2

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0004 · 101,415 in / 5,330 out · 28,416 cached (28%) · ladder/vectors-oai3, deepseek-v4.1-flash · 85 embedded
critique:    $0.0001 · 40,970 in  / 1,047 out · 16,384 cached (40%) · deepseek-v4.1-flash
security:    $0.0001 · 41,322 in  / 662 out   · 6,144 cached (15%)  · deepseek-v4.1-flash
description: $0.0001 · 17,073 in  / 1,464 out · 5,888 cached (34%)  · deepseek-v4.1-flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant