fix(settings): Background Loops page layout overflow and duplicate label#2693
fix(settings): Background Loops page layout overflow and duplicate label#2693graycyrus wants to merge 4 commits into
Conversation
… spawn gate (tinyhumansai#2365) The `integrations_agent` spawn-gate used to emit the same "available but the user has not authorized it yet" copy regardless of WHY a Composio connection wasn't usable — whether the OAuth was still in flight (`INITIATED`), the token had rolled over (`EXPIRED`), or the handshake had failed outright (`FAILED`). Users who saw Gmail showing as connected in Settings would then see the agent say "Gmail isn't connected", concluded the app was broken, and opened the issue. Settings UI reflects the FE's optimistic post-OAuth view; the spawn-gate reads the backend's authoritative `list_connections` status. When those diverge — most commonly because OAuth never reached `ACTIVE` — the user-facing message has to be precise enough that the user can act on the actual situation, not retry the same flow. Wire path - `ConnectedIntegration` gains a `non_active_status: Option<String>` field carrying the most-informative upstream status for toolkits in the backend allowlist that lack an ACTIVE connection row. `EXPIRED > FAILED/ERROR > INITIATED/INITIALIZING/PENDING > other`. - `fetch_connected_integrations_uncached` builds a per-slug map from the raw `connections` vec (filtered to non-active rows that don't have a competing ACTIVE row for the same slug) and feeds the prioritised status into every emitted `ConnectedIntegration`. - `spawn_subagent`'s integrations_agent gate routes through a new `describe_unconnected_state(toolkit, status)` helper instead of the inline literal. Five distinct messages: INITIATED/INITIALIZING/PENDING → "finish the browser OAuth flow" EXPIRED → "reconnect — token expired" FAILED/ERROR → "reconnect — previous attempt failed" other non-empty status → quoted verbatim for triage None (no row at all) → legacy "never authorized" copy - All 14 `ConnectedIntegration { ... }` literal sites updated to carry the new field. Test fixtures all use `None`. Tests (in `spawn_subagent::tests`, 7 new, 13 passing in the targeted filter; 57 passing in `composio::ops`) - INITIATED / PENDING / INITIALIZING all route to the OAuth-in-progress branch and explicitly do NOT borrow the legacy "has not authorized it yet" wording — that was the actual user-perception bug from tinyhumansai#2365 (Settings showed Gmail connected, agent said "not authorized"). - EXPIRED → reconnect copy with `OAuth token has expired`. - FAILED / ERROR → reconnect copy with `FAILED state`. - Unknown status (e.g. `DEAUTH_REQUIRED`) is quoted verbatim so triage can act on it without needing a code change. - None → preserves the legacy never-connected copy. - Case-insensitive matching (`initiated`, `Expired`) routes the same way as the canonical uppercase form, since Composio's wire shape isn't case-stable. Acceptance criteria touched - [x] No false disconnected response: connections in the mid-OAuth / expired / failed states are now described with their actual state. - [x] Scope issue surfaced: scope-mismatch errors continue to flow through the existing `composio::error_mapping` `InsufficientScope` path; this PR doesn't regress that. - [x] Connection state consistent: the gate now reads the same backend status the FE Settings UI reads. - [x] Regression safety: 7 new tests + 6 pre-existing integrations_agent gate tests still pass. Out of scope (separate PRs / not needed) - No FE change: the spawn-gate output bubbles up to the orchestrator, which paraphrases for the user. - No `is_active` change: pre-existing semantics (only ACTIVE / CONNECTED count as usable) are preserved; the new field only describes the *non-active* case. - No new RPC: the new field rides along the existing `ConnectedIntegration` payload used by the agent harness.
… verbatim status in unknown-status branch
CodeRabbit major finding on src/openhuman/tools/impl/agent/spawn_subagent.rs.
The previous `describe_unconnected_state` uppercased the status
once and then used the uppercased value in BOTH the match arms AND
the unknown-status format string, so a mixed-case wire value like
`DeauthRequired` was echoed back as `DEAUTH_REQUIRED` — breaking
the "quote unknown statuses verbatim" contract.
Fix
- Capture the trimmed original separately:
let trimmed = status.map(str::trim).filter(|s| !s.is_empty());
let upper = trimmed.map(|s| s.to_ascii_uppercase());
- Match on `upper.as_deref()` for the known branches.
- In the unknown-status branch, format with `trimmed.unwrap_or("")`
so the upstream casing is preserved verbatim.
- `filter(|s| !s.is_empty())` collapses whitespace-only inputs to
the truly-disconnected `_` branch (instead of formatting "" into
the unknown-status template).
Tests
- Expanded `describe_unconnected_state_quotes_unknown_status_verbatim`
to pin three shapes (uppercase / snake_case / PascalCase) so a
silent drift back to echoing the uppercased value fails CI.
- New `describe_unconnected_state_quotes_unknown_status_after_trimming_whitespace`
pins:
* blank/whitespace input collapses to the legacy `None` branch
* padded status is trimmed but its casing is preserved
- All other tests unchanged and still pass.
`cargo test --lib describe_unconnected_state` → 8 passed, 0 failed
(7 pre-existing + 1 new).
…icate label - Widen Settings container from max-w-lg (512px) to max-w-3xl (768px) so the two-column grid in BackgroundLoopControls can activate - Change two-column grid breakpoint from lg: to md: with reduced right column minimum (260px) to work within the wider container - Add min-w-0/overflow-hidden/truncate to MetricTile and FormulaRow components to prevent numbers and labels from overflowing their cards - Add min-w-0 to loop map grid children so loop names and descriptions don't wrap word-by-word at narrow widths - Change 3-select grid (Calendar cap / Meeting lookahead / Reminder lookahead) from md: to sm: breakpoint and add whitespace-nowrap to labels to prevent column headers from merging together - Add min-w-0/overflow-hidden to the usage ledger panel so the "WEEK" label and budget values are not cut off - Fix i18n key settings.ai.defaultResolvesTo from "OpenHuman" to "Default resolves to" (and localized equivalents) across all 15 locale files, eliminating the duplicate "OpenHuman OpenHuman." label Closes tinyhumansai#2579
📝 WalkthroughWalkthroughThis PR addresses two independent feature areas: frontend UI layout fixes with i18n updates, and backend integration status tracking with improved user messaging. The frontend changes fix overflow and truncation issues in the AIPanel settings component while updating the placeholder "OpenHuman" string to proper translations. The backend changes add non-active status tracking to ConnectedIntegration to surface real OAuth connection states and generate context-aware messaging when tools are allowlisted but pending authorization. ChangesFrontend UI and i18n updates
Integration status tracking and messaging
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/components/settings/panels/AIPanel.tsx`:
- Around line 1113-1115: The JSX currently contains hard-coded user-visible
strings (e.g., the label "Calendar cap" and the select option labels around
lines in AIPanel.tsx) which must be replaced with translations via useT();
update the component to call const t = useT() and replace those literal strings
with t('ai.calendarCap.label') (and analogous keys for the two other selects
referenced at 1131-1133 and 1149-1151), then add corresponding keys and English
values to app/src/lib/i18n/en.ts in this PR so the UI strings are localized.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4f606732-20e8-4f88-8422-7db2553e851b
📒 Files selected for processing (27)
app/src/components/settings/panels/AIPanel.tsxapp/src/lib/i18n/chunks/ar-4.tsapp/src/lib/i18n/chunks/bn-4.tsapp/src/lib/i18n/chunks/de-4.tsapp/src/lib/i18n/chunks/en-4.tsapp/src/lib/i18n/chunks/es-4.tsapp/src/lib/i18n/chunks/fr-4.tsapp/src/lib/i18n/chunks/hi-4.tsapp/src/lib/i18n/chunks/id-4.tsapp/src/lib/i18n/chunks/it-4.tsapp/src/lib/i18n/chunks/ko-4.tsapp/src/lib/i18n/chunks/pt-4.tsapp/src/lib/i18n/chunks/ru-4.tsapp/src/lib/i18n/chunks/zh-CN-4.tsapp/src/lib/i18n/en.tsapp/src/lib/i18n/ko.tsapp/src/pages/Settings.tsxsrc/openhuman/agent/agents/integrations_agent/prompt.rssrc/openhuman/agent/agents/orchestrator/prompt.rssrc/openhuman/agent/agents/welcome/prompt.rssrc/openhuman/agent/harness/subagent_runner/ops.rssrc/openhuman/agent/harness/test_support_test.rssrc/openhuman/agent/prompts/types.rssrc/openhuman/composio/ops.rssrc/openhuman/composio/ops_test.rssrc/openhuman/tools/impl/agent/spawn_subagent.rssrc/openhuman/tools/orchestrator_tools.rs
| <label className="min-w-0 space-y-1 text-xs font-medium text-stone-700 dark:text-neutral-200"> | ||
| <span className="whitespace-nowrap">Calendar cap</span> | ||
| <select |
There was a problem hiding this comment.
Replace hard-coded select labels with i18n keys via useT().
These three changed labels are user-visible literals in JSX and should be translated keys (useT()), with corresponding entries added to locale files.
As per coding guidelines: “Every user-visible string in app/src/** ... must go through useT() ... Hard-coded literals in JSX ... are not allowed. Add the new key to app/src/lib/i18n/en.ts in the same PR.”
Also applies to: 1131-1133, 1149-1151
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@app/src/components/settings/panels/AIPanel.tsx` around lines 1113 - 1115, The
JSX currently contains hard-coded user-visible strings (e.g., the label
"Calendar cap" and the select option labels around lines in AIPanel.tsx) which
must be replaced with translations via useT(); update the component to call
const t = useT() and replace those literal strings with
t('ai.calendarCap.label') (and analogous keys for the two other selects
referenced at 1131-1133 and 1149-1151), then add corresponding keys and English
values to app/src/lib/i18n/en.ts in this PR so the UI strings are localized.
graycyrus
left a comment
graycyrus
left a comment
There was a problem hiding this comment.
This is a DRAFT that bundles two separate fixes — the PR description only discloses one of them.
The CSS/layout and i18n changes for #2579 are solid. Container widening to max-w-3xl, breakpoint shifts (lg: to md:, md:grid-cols-3 to sm:grid-cols-3), and the min-w-0/truncate/overflow-hidden additions across MetricTile, FormulaRow, loop map, and the usage ledger panel all make sense and will fix the reported overflow.
However, the diff also includes significant Rust backend work — a new non_active_status: Option<String> field on ConnectedIntegration, status-priority selection logic in composio/ops.rs, a new describe_unconnected_state() function in spawn_subagent.rs (addressing issue #2365), and 8 new tests — none of which appear in the PR title, summary, or checklist. The body explicitly states "CSS-only layout fixes and i18n text correction, no testable logic changes" and checks off "N/A: Tests added or updated", both of which contradict the actual diff.
The Rust work itself is good. The priority scheme for non-active statuses is sensible, the verbatim-quoting contract for unknown statuses (preserving trimmed rather than the uppercased form) correctly addresses the CodeRabbit finding from #2373, and the test suite is thorough. The non_active_status: None fixture updates across 6 test files are the right mechanical change.
Before marking ready:
- Update the title, summary, checklist, and Related section to reflect both #2579 and #2365. Anyone approving on the stated scope is blind to the backend changes.
- The three
<span>labels in the three-select grid ("Calendar cap", "Meeting lookahead", "Reminder lookahead") are hard-coded user-visible literals — needsuseT(). CodeRabbit already flagged the specifics.
| pub non_active_status: Option<String>, | ||
| } | ||
|
|
||
| /// A toolkit action that exists in the catalog but is currently hidden from |
There was a problem hiding this comment.
[major] This field and the related logic in composio/ops.rs and spawn_subagent.rs address issue #2365 — but the PR description says this is a CSS-only/i18n change with no logic changes and marks tests as N/A. Update the description, checklist, and Related section before marking ready.
2 participants
Summary
settings.ai.defaultResolvesToi18n key across all 15 locale files.max-w-lgtomax-w-3xlso the two-column grid can activate.Problem
settings.ai.defaultResolvesTowas incorrectly set to"OpenHuman"instead of"Default resolves to", causing the template{t('settings.ai.defaultResolvesTo')} <span>OpenHuman</span>.to render as "OpenHuman OpenHuman."Solution
min-w-0,overflow-hidden, andtruncateto MetricTile, FormulaRow, loop map grid children, and the usage ledger panel to prevent content overflow.lg:tomd:with a reduced right-column minimum (260px) so the layout activates within the widened container.md:grid-cols-3tosm:grid-cols-3and addedwhitespace-nowrapto labels to prevent header merging.settings.ai.defaultResolvesToi18n value to localized "Default resolves to" across all locale files.Submission Checklist
Closes #2579in the Related sectionImpact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
Validation Run
pnpm --filter openhuman-app format:checkpnpm typecheckValidation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Parity Contract
Duplicate / Superseded PR Handling
Summary by CodeRabbit
UI/UX Improvements
New Features
Localization