EACQAPW-5778 Изменен класс Receipt.kt на основе выборки между версиями фискализации #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harcoPro
reviewed
Aug 9, 2023
| data class ReceiptFfd12( | ||
|
|
||
| /** | ||
| * Общие проперти |
| } | ||
|
|
||
| receipt.apply(initializer) | ||
| return receipt |
Contributor
There was a problem hiding this comment.
Дублирование этой функции в InitRequest и в ConfirmRequest - зачем?
Вынеси ее куда нибудь и используй где нужно.
Так же я не увидел чтобы она где-то использовалась.
Для чего она нужна, если она ни где не используется?
| when (receipt) { | ||
| is ReceiptFfd105 -> (receipt as ReceiptFfd105).email = email | ||
| is ReceiptFfd12 -> (receipt as ReceiptFfd12).base.email = email | ||
| } |
Contributor
There was a problem hiding this comment.
То же самое. Дублируются функции.
Выноси куда-то в отдельное место, зачем писать одинаковый код в разных местах?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.