migrate: useSyncExternalStore instead of useState at useStore #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@yunho1017 is attempting to deploy a commit to the analytics-billing-vtest314 Team on Vercel. A member of the Team first needs to authorize it. |
yunho1017
force-pushed
the
feature/useSyncExternalStore
branch
from
b154d50 to
61ae706
Compare
|
Hi, thanks for the PR! I'm closing it in favour of #359, which I'll merge soon. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is
useStore Hook is adding a listener in useEffect to update state.
To-be
Changed to use useSyncExternalStore.
After react18, ConcurrentFeature can cause a Tearing problem in the External Store. UseSyncExternalStore to fix this problem.