Skip to content

Migrate to latest Sass syntax#15

Merged
timobrembeck merged 2 commits into
timobrembeck:mainfrom
RobinvanderVliet:patch-1
Jul 5, 2026
Merged

Migrate to latest Sass syntax#15
timobrembeck merged 2 commits into
timobrembeck:mainfrom
RobinvanderVliet:patch-1

Conversation

@RobinvanderVliet

Copy link
Copy Markdown
Contributor

I ran the following command in the folder src: sass-migrator module flagpack.scss

Please check whether this fully solves the issue.

Fixes #14

@timobrembeck timobrembeck left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, sorry for the long silence — this PR deserved a response much sooner. Thanks a lot for the migration to the Sass module system! The change compiles cleanly and the generated CSS is byte-identical to the current dist/flagpack.css. 🎉

One side effect of @use: the customization pattern documented in the README (defining variables like $fp-prefix before importing) no longer has any effect, because module variables can only be configured via @use ... with (...). I've pushed a small commit to your branch that updates the README's SASS section with the new pattern:

@use "flagpack-dart-sass/src/variables" with (
  $fp-prefix: "flag",
  $fp-countries: ("bo", "de", "us")
);
@use "flagpack-dart-sass/src/flagpack";

Since this changes the public configuration API for everyone using the Sass files directly, I'll release it as a major version bump.

@timobrembeck timobrembeck merged commit ea3d87f into timobrembeck:main Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix deprecation warnings on @import rules

2 participants