Migrate to latest Sass syntax#15
Merged
Merged
Conversation
timobrembeck
approved these changes
Jul 5, 2026
timobrembeck
left a comment
Owner
There was a problem hiding this comment.
First of all, sorry for the long silence — this PR deserved a response much sooner. Thanks a lot for the migration to the Sass module system! The change compiles cleanly and the generated CSS is byte-identical to the current dist/flagpack.css. 🎉
One side effect of @use: the customization pattern documented in the README (defining variables like $fp-prefix before importing) no longer has any effect, because module variables can only be configured via @use ... with (...). I've pushed a small commit to your branch that updates the README's SASS section with the new pattern:
@use "flagpack-dart-sass/src/variables" with (
$fp-prefix: "flag",
$fp-countries: ("bo", "de", "us")
);
@use "flagpack-dart-sass/src/flagpack";
Since this changes the public configuration API for everyone using the Sass files directly, I'll release it as a major version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran the following command in the folder
src:sass-migrator module flagpack.scssPlease check whether this fully solves the issue.
Fixes #14