Open
Conversation
This will help catch a potential use-after-free when a cache entry is used after unpinning it. In normal builds, it is not released eagerly, so the Address Sanitizer cannot detect it as a use after free.
|
@kpan2034, @melihmutlu: please review this pull request.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
svenklemm
approved these changes
Apr 2, 2026
Member
|
There is also CLOBBER_FREED_MEMORY on postgres side to make finding use after free easier |
Member
Author
That one is included when you enable the assertions. With these new flags, the sanitizer build now takes more than two hours. Maybe I'll only enable it on a single scheduled run on one config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help catch a potential use-after-free when a cache entry is used after unpinning it. In normal builds, it is not released eagerly, so the Address Sanitizer cannot detect it as a use after free.
Helpful for finding things like #9487 and #9486