Add #[inline]
to Time::from_hms
for performance
#748
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes decoding
Time
inbitcode
6X faster.It works since
bitcode
checks the range of integers up front, all at once, using vector instructions, and then usesunreachable_unchecked
right before callingTime::from_hms
to communicate that fact torustc
. This only works ifTime::from_hms
is inlinable.