atomic64: Use AtomicUsize on 64-bit targets #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalmarhubi
force-pushed
the
atomics-on-stable-64
branch
from
c040869 to
04453c4
Compare
|
CI should be extended to cover some of these combinations. Probably ok in a later PR? |
|
Test failure is unrelated. Fixed in #83; can rebase after that's merged. |
overvenus
approved these changes
Nov 4, 2016
There was a problem hiding this comment.
LGTM
@kamalmarhubi Thank you very much! There will be a huge performance leap for most stable build. 👍
|
Thanks @kamalmarhubi Could you merge the master and fix the CI ? |
Preparation for refactoring to separate modules for each implementation. This commit will make later diffs easier to read.
Conditionally use the relevant file to separate out the different implementations.
This builds on the work in tikv#64 to allow stable Rust users to get atomics if they run on 64-bit architectures. Benchmark improvements: name old ns/iter new ns/iter diff ns/iter diff % counter::bench_counter_no_labels 49 16 -33 -67.35% counter::bench_counter_with_label_values 195 139 -56 -28.72% counter::bench_counter_with_mapped_labels 715 371 -344 -48.11% counter::bench_counter_with_prepared_mapped_labels 436 219 -217 -49.77% gauge::bench_gauge_no_labels 48 15 -33 -68.75% gauge::bench_gauge_with_label_values 167 115 -52 -31.14% histogram::bench_histogram_no_labels 179 30 -149 -83.24% histogram::bench_histogram_timer 276 138 -138 -50.00% histogram::bench_histogram_with_label_values 363 137 -226 -62.26% Benchmarks run with default features (no "nightly" feature) on nightly-2016-09-22, which corresponds roughly to 1.12.0. Tested: Ran tests on the following combinations (all unknown-linux-gnu): - stable Rust x86_64 - stable Rust i686 - nightly Rust x86_64 - nightly Rust i686 - nightly Rust x86_64 with `--features=nightly` - nightly Rust i686 with `--features=nightly`
kamalmarhubi
force-pushed
the
atomics-on-stable-64
branch
from
04453c4 to
f6a4a0e
Compare
|
I rebased this to pick up the lint fix in #83. But don't merge this until I send up the CI improvements (wip, will be a separate PR). I'll rebase this again after that is merged. |
|
LGTM |
|
PTAL @BusyJay |
|
Just to make it clear this shouldn't be merged till after the CI improvements, I'm closing the PR for now. Will reopen hopefully in the next day or two. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the work in #64 to allow stable Rust users to get atomics
if they run on 64-bit architectures.
Benchmark improvements:
Benchmarks run with default features (no "nightly" feature) on
nightly-2016-09-22, which corresponds roughly to 1.12.0.
Tested:
Ran tests on the following combinations (all unknown-linux-gnu):
- stable Rust x86_64
- stable Rust i686
- nightly Rust x86_64
- nightly Rust i686
- nightly Rust x86_64 with
--features=nightly- nightly Rust i686 with
--features=nightly