Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support musl #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Support musl #32

wants to merge 1 commit into from

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jul 9, 2020

Signed-off-by: Yang Keao [email protected]

Related with #27 . But there are still problems to build on musl:

  1. symbolic-demangle has to be modified to avoid dynamic linking with stdc++. cpp_link_stdlib(None) can simply solve this.

  2. The backtrace works not well:

image

Here is an example running the multithread_flamegraph 😢 .

Signed-off-by: Yang Keao <[email protected]>
@xhebox
Copy link
Contributor

xhebox commented Nov 1, 2020

Any new progress? I can help, I am on a native musl host.

@YangKeao YangKeao mentioned this pull request Nov 2, 2020
@YangKeao
Copy link
Member Author

YangKeao commented Nov 2, 2020

@xhebox Really thanks for your help! It would be appreciated to submit a PR and make it work with musl. If you need any help on pprof-rs, feel free to contact me (under #41, or through email).

There is no new progress for this PR 😭 . I have tried to modify symbolic-demangle and make it compiled under musl. However, as shown before, it works not well. Once your commits arrive, I would close this one.

@xhebox
Copy link
Contributor

xhebox commented Nov 2, 2020

Oh, the flame graph? Maybe there is a workaround.. But maybe not, I will look into this and ask the author of musl-libc for some help.

The problem is that it is blocking my compilation of tikv. I do not really need a well working pprof on musl. Backtracing never works well on musl... Maybe could, somehow, first pass the build of tikv.

@YangKeao
Copy link
Member Author

YangKeao commented Nov 2, 2020

@xhebox Well. It would be better to use conditional compilation and target specified dependency to avoid building pprof-rs on musl.

@BohuTANG
Copy link

@YangKeao

Hello, are there any plans to restart this pr?

@fredr
Copy link

fredr commented Dec 19, 2022

I ended up here after getting empty profiles from our services built with musl. I wasn't sure what the status was, are we still waiting for something to be released in #41, or do we know what is not working with musl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants