Put a flag on what morph class to return from a child#147
Open
mattzuba wants to merge 1 commit intotighten:mainfrom
Open
Put a flag on what morph class to return from a child#147mattzuba wants to merge 1 commit intotighten:mainfrom
mattzuba wants to merge 1 commit intotighten:mainfrom
Conversation
mattzuba
force-pushed
the
fix-for-reflection-lazy-proxy
branch
from
908603a to
91f072c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33 updated the getMorphClass method to return the parent's morph class. Livewire supports using ReflectionClass::newLazyProxy if running on PHP 8.4+. This causes issues when the ReflectionClass instance is created using the parent class, but the callback function returns the child. So for my use case, I needed to return the parent::getMorphClass value from the child, not the parent classes getMorphClass value.
This change adds a simple boolean flag/property that can be added to child classes to use parent::getMorphClass. Also maintains backwards compatibility with what #33 implemented to not break anyone. Test cases to replicate included as well.