Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RS-2338] Update WAF docs following changes to configmap name and format #1886

Merged
merged 4 commits into from
Mar 14, 2025

Conversation

gantony
Copy link
Contributor

@gantony gantony commented Feb 7, 2025

Product Version(s):
3.21 EP2 (so master only for now)

Issue:
https://tigera.atlassian.net/browse/RS-2338

Epic: https://tigera.atlassian.net/browse/PMREQ-704

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit f42eb00
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/67d451c9676e070008a505ba
😎 Deploy Preview https://deploy-preview-1886--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for tigera failed. Why did it fail? →

Built without sensitive environment variables

Name Link
🔨 Latest commit f42eb00
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/67d451c9c3ecb800089e8fdd

@gantony gantony force-pushed the antony-waf-ruleset-updates branch from 227e397 to 4bb2cbb Compare February 7, 2025 12:11
@gantony gantony marked this pull request as ready for review February 19, 2025 11:43
@gantony gantony requested a review from a team as a code owner February 19, 2025 11:43
Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to merge?

Do we need to copy this to the corresponding CC location? Currently, that's calico-cloud.

@gantony
Copy link
Contributor Author

gantony commented Mar 10, 2025

Do we need to copy this to the corresponding CC location? Currently, that's calico-

This is not available in Calico Cloud and will be when 3.21 EP2 is validated (not yet) and used in CC (not listed in https://tigera.atlassian.net/projects/PMREQ?selectedItem=com.atlassian.jira.jira-projects-plugin%3Arelease-page, so I assume early May release at the earliest).

I assume it's too early to update the docs?

If there is nothing to do, yes, that's ready to merge.

@ctauchen
Copy link
Collaborator

@gantony We're ready now to take changes related to 3.21 ep2 in the CC next directory (calico-cloud/threat/web-application-firewall.mdx). If you make the changes there, then they'll be ready for whenever CC picks up that version.

@ctauchen
Copy link
Collaborator

LGTM, thanks!

@ctauchen ctauchen merged commit 5f7e0e0 into tigera:main Mar 14, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants