Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override version for registry scanner #1397

Conversation

WilliamTigera
Copy link
Contributor

@WilliamTigera WilliamTigera commented Mar 28, 2024

Product Version(s):
Calico Cloud - standalone image for registry scanner

Issue:
Fix for: https://tigera.atlassian.net/browse/BAST-1286

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@WilliamTigera WilliamTigera requested a review from a team as a code owner March 28, 2024 18:30
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 5bd6dfc
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/6605b7dd76200c0008211798
😎 Deploy Preview https://deploy-preview-1397--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 57 (🔴 down 5 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (no change from production)
SEO: 79 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5bd6dfc
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/6605b7dd4125f7000837a5a9
😎 Deploy Preview https://deploy-preview-1397--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 42 (🔴 down 27 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@WilliamTigera WilliamTigera force-pushed the new-registry-scanner-override-version branch from 88eb29f to 5bd6dfc Compare March 28, 2024 18:32
Copy link
Contributor

@stevegaossou stevegaossou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion.

@@ -53,7 +53,7 @@ To deploy the registry scanner as a pod in Kubernetes cluster, we recommend that

### Download the registry scanner

The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:{{imageassuranceversion}}`.
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:v1.15.3`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth adding a ToDo comment just to mark down that we're explicitly coming back here to switch it to the imageassuranceversion parameter on the next release.

Copy link
Collaborator

@ctauchen ctauchen Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamTigera Best to revert changes to this doc. That way, this version mismatch will stay in production only for CC 19.1. We'll be cutting the new version for the next release, 19.2, which incorporates CE 3.19ep2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

@@ -53,7 +53,7 @@ To deploy the registry scanner as a pod in Kubernetes cluster, we recommend that

### Download the registry scanner

The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:{{imageassuranceversion}}`.
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:v1.15.3`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth adding a ToDo comment just to mark down that we're explicitly coming back here to switch it to the imageassuranceversion parameter on the next release.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need. Next release will be cut from ./calico-cloud/, where we are not making the change.

Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things. I've changed the destination branch to our CC19.2 publication branch, publish/cc-19.1. We can merge when you've made changes.

@@ -53,7 +53,7 @@ To deploy the registry scanner as a pod in Kubernetes cluster, we recommend that

### Download the registry scanner

The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:{{imageassuranceversion}}`.
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:v1.15.3`.
Copy link
Collaborator

@ctauchen ctauchen Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamTigera Best to revert changes to this doc. That way, this version mismatch will stay in production only for CC 19.1. We'll be cutting the new version for the next release, 19.2, which incorporates CE 3.19ep2.

@@ -53,7 +53,7 @@ To deploy the registry scanner as a pod in Kubernetes cluster, we recommend that

### Download the registry scanner

The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:{{imageassuranceversion}}`.
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:v1.15.3`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need. Next release will be cut from ./calico-cloud/, where we are not making the change.

@ctauchen ctauchen changed the base branch from main to publish/cc-19.1 March 29, 2024 09:55
@ctauchen ctauchen merged commit e99db4a into tigera:publish/cc-19.1 Apr 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants