-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override version for registry scanner #1397
Override version for registry scanner #1397
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
88eb29f
to
5bd6dfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a suggestion.
@@ -53,7 +53,7 @@ To deploy the registry scanner as a pod in Kubernetes cluster, we recommend that | |||
|
|||
### Download the registry scanner | |||
|
|||
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:{{imageassuranceversion}}`. | |||
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:v1.15.3`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth adding a ToDo comment just to mark down that we're explicitly coming back here to switch it to the imageassuranceversion
parameter on the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamTigera Best to revert changes to this doc. That way, this version mismatch will stay in production only for CC 19.1. We'll be cutting the new version for the next release, 19.2, which incorporates CE 3.19ep2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted.
@@ -53,7 +53,7 @@ To deploy the registry scanner as a pod in Kubernetes cluster, we recommend that | |||
|
|||
### Download the registry scanner | |||
|
|||
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:{{imageassuranceversion}}`. | |||
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:v1.15.3`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth adding a ToDo comment just to mark down that we're explicitly coming back here to switch it to the imageassuranceversion
parameter on the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need. Next release will be cut from ./calico-cloud/, where we are not making the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things. I've changed the destination branch to our CC19.2 publication branch, publish/cc-19.1
. We can merge when you've made changes.
@@ -53,7 +53,7 @@ To deploy the registry scanner as a pod in Kubernetes cluster, we recommend that | |||
|
|||
### Download the registry scanner | |||
|
|||
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:{{imageassuranceversion}}`. | |||
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:v1.15.3`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamTigera Best to revert changes to this doc. That way, this version mismatch will stay in production only for CC 19.1. We'll be cutting the new version for the next release, 19.2, which incorporates CE 3.19ep2.
@@ -53,7 +53,7 @@ To deploy the registry scanner as a pod in Kubernetes cluster, we recommend that | |||
|
|||
### Download the registry scanner | |||
|
|||
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:{{imageassuranceversion}}`. | |||
The registry scanner comes in a Docker image. To get the image, run this command: `docker pull quay.io/tigera/image-assurance-registry-scanner:v1.15.3`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need. Next release will be cut from ./calico-cloud/, where we are not making the change.
Product Version(s):
Calico Cloud - standalone image for registry scanner
Issue:
Fix for: https://tigera.atlassian.net/browse/BAST-1286
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: