Fix handling of non-paged pages in double-page view #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t11r
requested review from
Faizan-hub,
ipf,
jfrer,
mohdUwaish59,
orlinmalkja,
paulpestov and
ubbo
ubbo
approved these changes
Oct 22, 2025
ubbo
left a comment
ubbo
left a comment
There was a problem hiding this comment.
i did compare with tify online and with this MR this really looks better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check https://tify-iiif-viewer.github.io/tify/264/?manifest=https%3A%2F%2Ftify.rocks%2Fmanifests%2Fiiif-cookbook-collection.json&tify=%7B%22childManifestUrl%22%3A%22https%3A%2F%2Fiiif.io%2Fapi%2Fcookbook%2Frecipe%2F0035-foldouts%2Fmanifest.json%22%2C%22pages%22%3A%5B-1%2C4%5D%7D. For all following pages, the even/odd order is reversed (5 is verso, 6 is recto) due to one non-paged page (“foldout”).