Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'disabled' state to rule list #223

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Add 'disabled' state to rule list #223

merged 3 commits into from
Nov 30, 2024

Conversation

bnichs
Copy link
Contributor

@bnichs bnichs commented Nov 1, 2024

Adds a "disabled" string to filter rule entries.

@tien
Copy link
Owner

tien commented Nov 12, 2024

Hey @bnichs thanks for contributing, can you add translations for other languages via string resource? Even basic translation from google translate is okay and can be improved later on.

@bnichs
Copy link
Contributor Author

bnichs commented Nov 12, 2024

Added the translations. Also i've never used this language before so let me know if there's a cleaner way of doing the string interpolation.

@tien
Copy link
Owner

tien commented Nov 13, 2024

@bnichs The CI workflow can't build and give this error for some reason FilterRulesScreen.kt:217:53 Unresolved reference 'not' for operator '!'

@bnichs
Copy link
Contributor Author

bnichs commented Nov 15, 2024

I've pushed a possible fix but im unable to kick off create-test-build to test it.

@tien tien merged commit 13e8b70 into tien:main Nov 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants