Skip to content

fix: Avoid putting <body> inside <head> #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hadley merged 1 commit into from
Jun 18, 2025
Merged

fix: Avoid putting <body> inside <head> #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions themes/hugo-graphite/layouts/_default/baseof.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,39 @@
<!DOCTYPE html>
<html>

<head>
{{ partial "header.html" . }}
</head>
<body>


{{ block "main" . }}
<body>
<div id="appTidyverseSite" {{ if not .IsHome }}class="shrinkHeader alwaysShrinkHeader" {{ end }}>
<div id="main">
<!-- rstudio header -->
<div id="rStudioHeader">
<nav class="band">
<div class="innards bandContent">
<div>
{{ if .Site.Params.logo.image }}
<a href="{{ " /" | relURL }}" class="nav-logo">
<img src="{{ print " images/" .Site.Params.logo.image | relURL }}" width="{{ .Site.Params.logo.width }}"
height="{{ .Site.Params.logo.height }}" alt="{{ .Site.Params.logo.alt }}">
</a>
{{- else -}}
<a class="productName" href="{{ " /" | relLangURL }}">{{- .Site.Title -}}</a>
{{ end }}
</div>
{{ partial "nav.html" . }}
</div>
</nav>
</div>
<main>
{{ block "main" . }}
</main>
<!-- The part of the page that begins to differ between templates -->
{{ end }}
{{ partial "footer.html" . }}
{{ end }}
{{ partial "footer.html" . }}
</div>
</div>
</body>

</html>
21 changes: 0 additions & 21 deletions themes/hugo-graphite/layouts/partials/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,3 @@

<!--this loads all stylesheets, metadata tags, favicons, and jquery -->
{{ partial "head_includes.html" . }}

<body>
<div id="appTidyverseSite" {{ if not .IsHome }}class="shrinkHeader alwaysShrinkHeader"{{ end }}>
<div id="main">
<!-- rstudio header -->
<div id="rStudioHeader">
<div class="band">
<div class="innards bandContent">
<div>
{{ if .Site.Params.logo.image }}
<a href="{{ "/" | relURL }}" class="nav-logo">
<img src="{{ print "images/" .Site.Params.logo.image | relURL }}" width="{{ .Site.Params.logo.width }}" height="{{ .Site.Params.logo.height }}" alt="{{ .Site.Params.logo.alt }}">
</a>
{{- else -}}
<a class="productName" href="{{ "/" | relLangURL }}">{{- .Site.Title -}}</a>
{{ end }}
</div>
{{ partial "nav.html" . }}
</div>
</div>
</div>
2 changes: 1 addition & 1 deletion themes/hugo-graphite/static/css/main-site.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ html, body {
/* to help push the footer down */
height: 100%; }

#root, #appShinySite, #main {
#root, #appTidyverseSite, #main {
position: absolute;
top: 0px;
left: 0px;
Expand Down