hms support for boolean operations with strings (#108)#115
Draft
zWarMob wants to merge 3 commits intotidyverse:mainfrom
Draft
hms support for boolean operations with strings (#108)#115zWarMob wants to merge 3 commits intotidyverse:mainfrom
zWarMob wants to merge 3 commits intotidyverse:mainfrom
Conversation
Member
|
Thanks. I wonder if we should make this comparison an error instead. What do you expect with |
eitsupi
reviewed
Jul 6, 2025
Comment on lines
+281
to
+291
| Ops.hms <- function (e1, e2) { | ||
| boolean <- switch(.Generic, `<` = , `>` = , `==` = , `!=` = , | ||
| `<=` = , `>=` = TRUE, FALSE) | ||
| if (boolean) { | ||
| if (inherits(e1, "hms") & inherits(e2, "character")) | ||
| e1 <- as.character(e1) | ||
| if (inherits(e2, "hms") & inherits(e1, "character")) | ||
| e2 <- as.character(e2) | ||
| } | ||
| NextMethod(.Generic) | ||
| } |
Contributor
There was a problem hiding this comment.
Since hms is based on the vctrs package, I believe the recommended way is to implement the vec_ptype2 and vec_cast methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The class
hmscan not be compared with strings#108
Expected behavior
Actual behavior