Export ProviderOpenAICompatible and generics#1047
Draft
thisisnic wants to merge 5 commits into
Draft
Conversation
Collaborator
Author
|
CI failures due to rlang 1.3.0 release and fixed by #1048 |
Collaborator
Author
|
Marking as draft as exporting all these generics might not be the right design decision - will wait to see if |
thisisnic
force-pushed
the
595-exports-classes
branch
from
ec19c3f to
99620ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #595
This PR exports
Chat,ToolDef,ProviderOpenAICompatible, and the provider generics so that downstream packages can create custom providers by subclassingProviderOpenAICompatible.I'm unsure on if this approach is desired though as
chat_openai_compatible()(implemented after the original issue was opened) already covers the common case (custom endpoint + auth + extra args). This PR goes further by exporting the class and generics so downstream packages can subclassProviderOpenAICompatibleand override specific behavior (e.g. response parsing, parameter mapping). Is that level of extensibility something we want to support?