- 
                Notifications
    
You must be signed in to change notification settings  - Fork 34
 
Non unique uid entrypoint #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            osteffenrh
  wants to merge
  1
  commit into
  tianocore:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
osteffenrh:non-unique-uid-entrypoint
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    2cd0be8    to
    eb76f08      
    Compare
  
    | 
           Oh, this one has been sitting here for a while. I forgot...  | 
    
Don't abort the entrypoint script if the user-id already exists. This allows using the dev images as root or when using Podman, which does some user mapping already. This should fix tianocore#76 Signed-off-by: Oliver Steffen <[email protected]>
eb76f08    to
    45108ea      
    Compare
  
    
      
  
  Closed
  
    
  osteffenrh 
      added a commit
        to osteffenrh/edk2-containers
      that referenced
      this pull request
    
      Dec 6, 2023 
    
    
      
  
    
      
    
  
Don't abort the entrypoint script if the user-id already exists. This allows using the dev images as root or when using Podman, which does some user mapping already. See issue tianocore#76 and PR tianocore#77. Signed-off-by: Oliver Steffen <[email protected]>
      
     Merged
  
    
  osteffenrh 
      added a commit
        to osteffenrh/edk2-containers
      that referenced
      this pull request
    
      Dec 6, 2023 
    
    
      
  
    
      
    
  
Don't abort the entrypoint script if the user-id already exists. This allows using the dev images as root or when using Podman, which does some user mapping already. See issue tianocore#76 and PR tianocore#77. Signed-off-by: Oliver Steffen <[email protected]>
    
  osteffenrh 
      added a commit
      that referenced
      this pull request
    
      Dec 8, 2023 
    
    
      
  
    
      
    
  
* Fedora 39: Use Qemu from package repo Fedora 39 ships Qemu 8. We can use that instead of building it from source. Also add Qemu for RiscV. Signed-off-by: Oliver Steffen <[email protected]> * Allow using dev image as root Don't abort the entrypoint script if the user-id already exists. This allows using the dev images as root or when using Podman, which does some user mapping already. See issue #76 and PR #77. Signed-off-by: Oliver Steffen <[email protected]> * Readme: Add Fedora 39 image to table Add links and badges for the Fedora 39 images to the table. Signed-off-by: Oliver Steffen <[email protected]> --------- Signed-off-by: Oliver Steffen <[email protected]>
    
  zzdif 
      added a commit
        to zzdif/containers
      that referenced
      this pull request
    
      Mar 2, 2024 
    
    
      
  
    
      
    
  
* Add Fedora 39 image with gcc13 (tianocore#82) Added Fedora 39 base image, providing GCC13 and Python 3.12. Signed-off-by: Chao Li <[email protected]> * Fedora 39 fixups (tianocore#87) * Fedora 39: Use Qemu from package repo Fedora 39 ships Qemu 8. We can use that instead of building it from source. Also add Qemu for RiscV. Signed-off-by: Oliver Steffen <[email protected]> * Allow using dev image as root Don't abort the entrypoint script if the user-id already exists. This allows using the dev images as root or when using Podman, which does some user mapping already. See issue tianocore#76 and PR tianocore#77. Signed-off-by: Oliver Steffen <[email protected]> * Readme: Add Fedora 39 image to table Add links and badges for the Fedora 39 images to the table. Signed-off-by: Oliver Steffen <[email protected]> --------- Signed-off-by: Oliver Steffen <[email protected]> * Fedora 39 Build Fixes (tianocore#88) * Fedora39: Don't use fixed package versions Specifying version numbers for the packages provided by the Linux distribution is counterproductive. The available patchlevel versions of a package can change within a Fedora release. This can breaks image builds which requires additional manual work. Since the major versions stay fixed, there should not be any compatibility issues between image builds. Additionally, bug fixes are picked up automatically. This patch removes the explicit version numbers from the packages and installs the default versions instead. Signed-off-by: Oliver Steffen <[email protected]> * Fedora 39: Install python-setuptools via pip Install python-setuptools via pip instead of taking it from the Fedora repo. This avoids possible conflicts with `pip install --upgrade ...` Signed-off-by: Oliver Steffen <[email protected]> --------- Signed-off-by: Oliver Steffen <[email protected]> --------- Signed-off-by: Chao Li <[email protected]> Signed-off-by: Oliver Steffen <[email protected]> Co-authored-by: Chao Li <[email protected]> Co-authored-by: Oliver Steffen <[email protected]>
| 
           It looks like this needs some changes since for example the Fedora 35 container was removed.  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Allow non-unique/already existing user ID in the entrypoint script.
This makes it possible to use the image as root or with Podman
Issue #76
Containers Affected
All dev images.