Skip to content

fix: add scratchlist visibility setting#827

Closed
swear01 wants to merge 4 commits into
tiann:mainfrom
swear01:fix/issue-812-scratchlist-settings
Closed

fix: add scratchlist visibility setting#827
swear01 wants to merge 4 commits into
tiann:mainfrom
swear01:fix/issue-812-scratchlist-settings

Conversation

@swear01
Copy link
Copy Markdown
Contributor

@swear01 swear01 commented Jun 6, 2026

Closes #812

Summary

  • Add a Chat settings toggle for Scratchlist, placed below Terminal Tool Cards.
  • Default Scratchlist to off so it does not take chat space unless enabled.
  • Restyle Scratchlist to use the user-message chat surface and normal borders instead of warning/amber colors.
  • Document local .git/info testing notes in AGENTS.md to avoid testing the wrong worktree.

Test plan

  • cd web && bun run test -- src/hooks/useScratchlistEnabled.test.ts src/components/AssistantChat/ScratchlistPanel.test.tsx src/routes/settings/index.test.tsx
  • bun typecheck && bun run test
  • Manual smoke on isolated hub/runner from /tmp/hapi-issue-812

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • No issues found in the modified lines.

Summary
Review mode: initial

Reviewed the latest diff for the scratchlist visibility preference, settings UI, localization strings, and related tests. Residual risk: I could not run the focused web checks in this runner because bun is unavailable.

Testing

  • Not run: bun not found in runner (bun run typecheck:web; focused web tests).

HAPI Bot

@heavygee
Copy link
Copy Markdown
Collaborator

heavygee commented Jun 6, 2026

Hey @swear01 - thanks for picking up #812. Heads-up before this lands: I have a v1.1 in flight in #798 that turns the panel into a drawer toggled by a composer button. By default it isn't mounted at all, so "takes chat space" disappears at the architectural level - opt-in via the composer instead of opt-out via Settings. That makes your useScratchlistEnabled hook + Settings entry redundant in the v1.1 world.

I'd rather land #798 as the answer to #812 than ship both and rip half of yours out next week. Both solve George's complaint; the deciding factor for me is avoiding churn, and since I built the feature originally the drawer is the shape I should have shipped first.

You're right that the amber chrome is too loud. I've absorbed your color restyle into #798 (commit 269b4370), with credit to you in the message. One nuance: in scratchlist mode the composer routes typed text into the drawer instead of chat, so we kept some signal of the destination change - the warning border stays as a subtle outline (no amber fill / text / focus ring anymore), and the strong destination indicator lives on the composer Send button (amber-500 only while routing). Cool with that compromise on top of your restyle?

Happy to keep this open until #798 is reviewed/merged, or close in favor of it - your call.

@swear01
Copy link
Copy Markdown
Contributor Author

swear01 commented Jun 7, 2026

Thanks for the context. That makes sense to me.

I'm good with closing this in favor of #798, as long as #798 references/closes #812 and keeps the softer scratchlist styling. The subtle border compromise sounds reasonable for indicating the composer destination change.

Thanks for absorbing the restyle and crediting it.

@swear01
Copy link
Copy Markdown
Contributor Author

swear01 commented Jun 7, 2026

Closing in favor of #798 per discussion above.

@heavygee
Copy link
Copy Markdown
Collaborator

heavygee commented Jun 7, 2026

Appreciate the call @swear01 - and to make sure your condition is locked in: I've updated the #798 body so it now closes both #797 and #812, with a callout linking back here and crediting your styling pass. The softer scratchlist chrome (drop the amber fill, neutral text/pill/focus, keep a subtle border accent) is in 269b4370 on that branch. Thanks for the quick handoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

草稿箱颜色与用户消息颜色保持一致 或者提供开关

2 participants