fix: add scratchlist visibility setting#827
Conversation
There was a problem hiding this comment.
Findings
- No issues found in the modified lines.
Summary
Review mode: initial
Reviewed the latest diff for the scratchlist visibility preference, settings UI, localization strings, and related tests. Residual risk: I could not run the focused web checks in this runner because bun is unavailable.
Testing
- Not run:
bunnot found in runner (bun run typecheck:web; focused web tests).
HAPI Bot
|
Hey @swear01 - thanks for picking up #812. Heads-up before this lands: I have a v1.1 in flight in #798 that turns the panel into a drawer toggled by a composer button. By default it isn't mounted at all, so "takes chat space" disappears at the architectural level - opt-in via the composer instead of opt-out via Settings. That makes your I'd rather land #798 as the answer to #812 than ship both and rip half of yours out next week. Both solve George's complaint; the deciding factor for me is avoiding churn, and since I built the feature originally the drawer is the shape I should have shipped first. You're right that the amber chrome is too loud. I've absorbed your color restyle into #798 (commit Happy to keep this open until #798 is reviewed/merged, or close in favor of it - your call. |
|
Thanks for the context. That makes sense to me. I'm good with closing this in favor of #798, as long as #798 references/closes #812 and keeps the softer scratchlist styling. The subtle border compromise sounds reasonable for indicating the composer destination change. Thanks for absorbing the restyle and crediting it. |
|
Closing in favor of #798 per discussion above. |
|
Appreciate the call @swear01 - and to make sure your condition is locked in: I've updated the #798 body so it now closes both #797 and #812, with a callout linking back here and crediting your styling pass. The softer scratchlist chrome (drop the amber fill, neutral text/pill/focus, keep a subtle border accent) is in |
Closes #812
Summary
.git/infotesting notes inAGENTS.mdto avoid testing the wrong worktree.Test plan
cd web && bun run test -- src/hooks/useScratchlistEnabled.test.ts src/components/AssistantChat/ScratchlistPanel.test.tsx src/routes/settings/index.test.tsxbun typecheck && bun run test/tmp/hapi-issue-812