fix(web): suppress Mermaid render error SVGs#813
Merged
Conversation
There was a problem hiding this comment.
Findings
No high-confidence issues found in the added or modified lines.
Summary
Review mode: initial
No correctness, security, regression, data-loss, performance, or maintainability issues found at >=80% confidence. Residual risk: this was a static review only; Mermaid behavior was checked against published Mermaid 11.14.0 declarations/source metadata, but browser rendering was not exercised.
Testing
Not run (automation)
HAPI Bot
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #785
Summary
mermaid.parse(..., { suppressErrors: true }); invalid syntax falls back to the source block without callingrender.Notes
Test plan
bun typecheckbun run test:cli— 93 files / 847 tests passedbun run test:hub— 263 tests passedbun run test:web— 89 files / 766 tests passedbun run test:shared— 68 tests passedbun run --cwd web test src/components/assistant-ui/mermaid-diagram.test.tsx— 3 tests passed