Skip to content

Conversation

@backslashxx
Copy link
Contributor

@backslashxx backslashxx commented Jun 12, 2025

Skip directories that does NOT have the same magic as /data/app.
This is to avoid scanning incfs and any other stacked filesystems.

While this is way dumber, it's way cheaper.
no kern_path(), no missable path_put(), no ref handling.

This supercedes
throne_tracker: avoid cross fs access (https://github.com/tiann/KernelSU/pull/2626)

Signed-off-by: backslashxx [email protected]

@backslashxx
Copy link
Contributor Author

backslashxx commented Jun 12, 2025

@tiann
#2632 (comment)

heres that "simpler cross-fs avoidance"

once this is in and then tested, I can re-prep kthread

Skip directories that does NOT have the same magic as /data/app.
This is to avoid scanning incfs and any other stacked filesystems.

While this is way dumber, it's way cheaper.
no kern_path(), no missable path_put(), no ref handling.

This supercedes
`throne_tracker: avoid cross fs access (https://github.com/tiann/KernelSU/pull/2626)`
- upstream tiann@0b6998b

Signed-off-by: backslashxx <[email protected]>
@backslashxx backslashxx force-pushed the simple-cross-fs-avoidance branch from d500b0d to f08e159 Compare June 12, 2025 04:19
@backslashxx backslashxx requested a review from tiann June 12, 2025 04:47
tiann
tiann previously approved these changes Jun 12, 2025
@backslashxx
Copy link
Contributor Author

for reference purposes, this change adds this

image

@aviraxp aviraxp merged commit d702e74 into tiann:main Jun 12, 2025
19 of 20 checks passed
@backslashxx backslashxx deleted the simple-cross-fs-avoidance branch June 12, 2025 06:43
rsuntk pushed a commit to rsuntk/KernelSU that referenced this pull request Jun 12, 2025
* Picked from tiann#2633
* Add missed filp_close and don't make data_app_magic static + __read_mostly

Signed-off-by: backslashxx <[email protected]>
Signed-off-by: rsuntk <[email protected]>
ShirkNeko pushed a commit to SukiSU-Ultra/SukiSU-Ultra that referenced this pull request Jun 12, 2025
* Picked from tiann/KernelSU#2633
* Add missed filp_close and don't make data_app_magic static + __read_mostly

Signed-off-by: backslashxx <[email protected]>
Signed-off-by: rsuntk <[email protected]>
luyanci pushed a commit to luyanci/KernelSU that referenced this pull request Jun 19, 2025
* Picked from tiann#2633
* Add missed filp_close and don't make data_app_magic static + __read_mostly

Signed-off-by: backslashxx <[email protected]>
Signed-off-by: rsuntk <[email protected]>
fadlyas07 added a commit to bengal-upstream/KernelSU that referenced this pull request Jul 10, 2025
* 'main' of https://github.com/tiann/KernelSU:
  kernel: selinux: rules: Fix illegal RCU lock usage in apply_kernelsu_rules() (tiann#2646)
  manger: fix lkm detection (tiann#2654)
  Update FUNDING.yml
  kernel: core_hook: fix refcount leaks on try_umount (tiann#2635)
  build(deps): bump the maven group across 1 directory with 7 updates (tiann#2629)
  Translations update from Hosted Weblate (tiann#2587)
  kernel: throne_tracker: avoid cross-fs traversal using s_magic check (tiann#2633)
  Switch to prepare_creds/commit_creds (tiann#2631)
  throne_tracker: avoid cross fs access (tiann#2626)
  build(deps): bump the maven group across 1 directory with 4 updates (tiann#2612)

 Conflicts:
	kernel/selinux/rules.c
	kernel/throne_tracker.c

Change-Id: If58573ef63cb613e76d6054c898c7748143ff8b9
LeCmnGend pushed a commit to LeCmnGend/KernelSU that referenced this pull request Sep 30, 2025
…iann#2633)

Skip directories that does NOT have the same magic as /data/app.
This is to avoid scanning incfs and any other stacked filesystems.

While this is way dumber, it's way cheaper.
no kern_path(), no missable path_put(), no ref handling.

This supercedes
`throne_tracker: avoid cross fs access
(https://github.com/tiann/KernelSU/pull/2626)`
- upstream
tiann@0b6998b

Signed-off-by: backslashxx
<[email protected]>
Prslc pushed a commit to Prslc/KernelSU that referenced this pull request Oct 31, 2025
…iann#2633)

Skip directories that does NOT have the same magic as /data/app.
This is to avoid scanning incfs and any other stacked filesystems.

While this is way dumber, it's way cheaper.
no kern_path(), no missable path_put(), no ref handling.

This supercedes
`throne_tracker: avoid cross fs access
(https://github.com/tiann/KernelSU/pull/2626)`
- upstream
tiann@0b6998b

Signed-off-by: backslashxx
<[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants