Fix cred and group refcount leaks #2628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviraxp
commented
Jun 10, 2025
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Jun 10, 2025
we remove that get_cred_rcu requirement by adding a hacky fallback to get_cred with smp_mb. YES, IT IS HACKY but it works well. Unlock earlier to reduce lock holding time. - !! EDIT this once tiann#2628 is merged Also properly reset refcount as said by cred.h by calling put_cred where the original unlock was. Signed-off-by: backslashxx <[email protected]>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Jun 10, 2025
we remove that get_cred_rcu requirement by adding a hacky fallback to get_cred with smp_mb. YES, IT IS HACKY but it works well. Unlock earlier to reduce lock holding time. - !! EDIT this once tiann#2628 is merged Also properly reset refcount as said by cred.h by calling put_cred where the original unlock was. Signed-off-by: backslashxx <[email protected]>
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Jun 10, 2025
- Picked some changes from tiann#2628 Signed-off-by: rsuntk <[email protected]>
luyanci
pushed a commit
to luyanci/KernelSU
that referenced
this pull request
Jun 10, 2025
- Picked some changes from tiann#2628 Signed-off-by: rsuntk <[email protected]>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Jun 11, 2025
we remove that get_cred_rcu requirement by adding a hacky fallback to get_cred with smp_mb. YES, IT IS HACKY but it works well. Unlock earlier to reduce lock holding time. - !! EDIT this once tiann#2628 is merged Also properly reset refcount as said by cred.h by calling put_cred where the original unlock was. Signed-off-by: backslashxx <[email protected]>
ShirkNeko
pushed a commit
to SukiSU-Ultra/SukiSU-Ultra
that referenced
this pull request
Jun 11, 2025
- Picked some changes from tiann/KernelSU#2628 Signed-off-by: rsuntk <[email protected]>
ShirkNeko
pushed a commit
to SukiSU-Ultra/SukiSU-Ultra
that referenced
this pull request
Jun 11, 2025
- Picked some changes from tiann/KernelSU#2628 Signed-off-by: rsuntk <[email protected]>
ShirkNeko
pushed a commit
to SukiSU-Ultra/SukiSU-Ultra
that referenced
this pull request
Jun 11, 2025
- Picked some changes from tiann/KernelSU#2628 Signed-off-by: rsuntk <[email protected]>
luyanci
pushed a commit
to luyanci/SukiSU-Ultra
that referenced
this pull request
Jun 11, 2025
- Picked some changes from tiann/KernelSU#2628 Signed-off-by: rsuntk <[email protected]>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Jun 12, 2025
we remove that get_cred_rcu requirement by adding a hacky fallback to get_cred with smp_mb. YES, IT IS HACKY but it works well. Unlock earlier to reduce lock holding time. - !! EDIT this once tiann#2628 is merged Also properly reset refcount as said by cred.h by calling put_cred where the original unlock was. Signed-off-by: backslashxx <[email protected]>
ShirkNeko
pushed a commit
to SukiSU-Ultra/SukiSU-Ultra
that referenced
this pull request
Jun 12, 2025
- Picked some changes from tiann/KernelSU#2628 Signed-off-by: rsuntk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.